Skip to content

add chainer, bump to 1.3 #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2018
Merged

add chainer, bump to 1.3 #195

merged 1 commit into from
May 24, 2018

Conversation

andremoeller
Copy link
Contributor

@andremoeller andremoeller commented May 24, 2018

Issue #, if available:

Description of changes: Adding chainer estimator, bumping version to 1.3

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andremoeller andremoeller requested review from owen-t, nadiaya and mvsusp May 24, 2018 16:11
@codecov-io
Copy link

Codecov Report

Merging #195 into master will increase coverage by 0.34%.
The diff coverage is 99.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   90.68%   91.03%   +0.34%     
==========================================
  Files          38       42       +4     
  Lines        2599     2699     +100     
==========================================
+ Hits         2357     2457     +100     
  Misses        242      242
Impacted Files Coverage Δ
src/sagemaker/predictor.py 96.83% <100%> (+1.24%) ⬆️
src/sagemaker/chainer/estimator.py 100% <100%> (ø)
src/sagemaker/chainer/__init__.py 100% <100%> (ø)
src/sagemaker/content_types.py 100% <100%> (ø) ⬆️
src/sagemaker/chainer/defaults.py 100% <100%> (ø)
src/sagemaker/fw_utils.py 98.52% <100%> (ø) ⬆️
src/sagemaker/chainer/model.py 96.55% <96.55%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 785f3b1...cba249e. Read the comment docs.

@andremoeller andremoeller merged commit c0ab61a into aws:master May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants