fix: use the provided kms key to upload user code

[Christian-kam]

Added entry for kms_key under Args for all the updated methods. Fix the missing space as per the build log file and also took care of the unused parameter.

Issue #, if available:

Description of changes:
In the fix #1897 that was recently merged, the kms key is not propagated throughout all the methods that require it to upload customer code.

For example:

• _normalize_args() #L208
• _include_code_in_inputs() #L496
• _handle_user_code_url() #L554
• _upload_code() #L581

This PR is to addresses the issue.

Testing done:
unit test

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

• I have read the CONTRIBUTING doc
• I used the commit message format described in CONTRIBUTING
• I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
• I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

• I have added tests that prove my fix is effective or that my feature works (if appropriate)
• I have checked that my tests are not configured for a specific region or account (if appropriate)
• I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[sagemaker-bot]

AWS CodeBuild CI Report

• CodeBuild project: sagemaker-python-sdk-unit-tests
• Commit ID: fa41066
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-bot]

AWS CodeBuild CI Report

• CodeBuild project: sagemaker-python-sdk-notebook-tests
• Commit ID: fa41066
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-bot]

AWS CodeBuild CI Report

• CodeBuild project: sagemaker-python-sdk-local-mode-tests
• Commit ID: fa41066
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-bot]

AWS CodeBuild CI Report

• CodeBuild project: sagemaker-python-sdk-pr
• Commit ID: fa41066
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[ajaykarpur]

Thank you for contributing @Christian-kam! Is this a duplicate of #1992?

[Christian-kam]

Thank you for contributing @Christian-kam! Is this a duplicate of #1992?

@ajaykarpur yes, after I made the changes to remove the white space in the code as per the build logs, I thought it would update the original pull request. I did not realize that it create a new one. The code in this one is the latest one.

[ajaykarpur]

Thank you! Could you please add unit and integration tests?

[Christian-kam]

Thank you! Could you please add unit and integration tests?

I am not really sure, how to add those tests. Can you please assist here?

[icywang86rui]

For unit test, you can add the kms_key arg to this test - https://github.com/aws/sagemaker-python-sdk/blob/master/tests/unit/test_processing.py#L257

For integ test you can create another key for testing like this - https://github.com/aws/sagemaker-python-sdk/blob/master/tests/integ/test_processing.py#L84
I would suggest just add the kms_key arg to one of the existing test's run method.

[icywang86rui]

There have been any actions for a few weeks. Closing for now. Feel free to reopen when you have the chance to add the tests.