Skip to content

fix: Check if metadata dir exists locally before mounting #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2020
Merged

fix: Check if metadata dir exists locally before mounting #2052

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2ba8f9
fix: Mount metadata dir only if it exists
rahul003 Dec 22, 2020
09505eb
Merge branch 'master' into checkdir
metrizable Dec 22, 2020
17ac9a5
Merge branch 'master' into checkdir
metrizable Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/sagemaker/local/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,12 @@ def _prepare_training_volumes(

volumes.append(_Volume(model_dir, "/opt/ml/model"))

# Mount the metadata directory on the notebook instance,
# this is used by some DeepEngine libraries
volumes.append(_Volume("/opt/ml/metadata", "/opt/ml/metadata"))
# Mount the metadata directory if present.
# Only expected to be present on SM notebook instances.
# This is used by some DeepEngine libraries
metadata_dir = "/opt/ml/metadata"
if os.path.isdir(metadata_dir):
volumes.append(_Volume(metadata_dir, metadata_dir))

# Set up the channels for the containers. For local data we will
# mount the local directory to the container. For S3 Data we will download the S3 data
Expand Down