Skip to content

fix: increase allowed time for search to get updated #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2021
Merged

fix: increase allowed time for search to get updated #2102

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a57fe2f
fix: increase allowed time to search
ahsan-z-khan Jan 22, 2021
79e3348
fix: add time for search to get updated
ahsan-z-khan Jan 22, 2021
8784910
Merge branch 'master' into fix-experiment-test
ahsan-z-khan Jan 22, 2021
1e4f011
Merge branch 'master' into fix-experiment-test
ahsan-z-khan Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions tests/integ/test_experiments_analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,17 @@ def experiment(sagemaker_session):

time.sleep(15) # wait for search to get updated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest keeping this initial sleep in place, since otherwise you'll allow no time for indexing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the initial sleep inside the loop to increase it 3 times. Does that allow time for indexing?


# allow search time thrice
for _ in range(3):
analytics = ExperimentAnalytics(
experiment_name=experiment_name, sagemaker_session=sagemaker_session
)

if len(analytics.dataframe().columns) > 0:
break

time.sleep(15)

yield experiment_name
finally:
_delete_resources(sm, experiment_name, trials)
Expand Down Expand Up @@ -79,6 +90,17 @@ def experiment_with_artifacts(sagemaker_session):

time.sleep(15) # wait for search to get updated

# allow search time thrice
for _ in range(3):
analytics = ExperimentAnalytics(
experiment_name=experiment_name, sagemaker_session=sagemaker_session
)

if len(analytics.dataframe().columns) > 0:
break

time.sleep(15)

yield experiment_name
finally:
_delete_resources(sm, experiment_name, trials)
Expand Down