-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test_tag/test_tags method assert fix in association tests #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The failure of sagemaker-python-sdk-pr is unrelated to the change made in this PR. (It shows failures in test_mxnet.py) |
@@ -66,7 +66,9 @@ def test_set_tag(association_obj, sagemaker_session): | |||
if actual_tags: | |||
break | |||
time.sleep(1) | |||
assert len(actual_tags) == 1 | |||
# When sagemaker-client-config endpoint-url is passed as argument to hit beta, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove reference to "beta" and just specify that for some endpoints, the number of tags may be greater than 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #, if available: https://sim.amazon.com/issues/AML-109079
Description of changes: Fix assert statements in test_tag/test_tags method in association tests
Testing done: tox -e py39 -- tests/integ/sagemaker/lineage --sagemaker-client-config {"endpoint_url":"https://api.sagemaker.beta.us-west-2.ml-platform.aws.a2z.com\"}
collected 30 items
tests/integ/sagemaker/lineage/test_action.py ....... [ 23%]
tests/integ/sagemaker/lineage/test_artifact.py ......... [ 53%]
tests/integ/sagemaker/lineage/test_association.py .... [ 66%]
tests/integ/sagemaker/lineage/test_context.py ....... [ 90%]
tests/integ/sagemaker/lineage/test_dataset_artifact.py . [ 93%]
tests/integ/sagemaker/lineage/test_endpoint_context.py . [ 96%]
tests/integ/sagemaker/lineage/test_model_artifact.py . [100%]