feature: update TF framework version support #2223

saimidu · 2021-03-17T17:30:02Z

Issue #, if available:

Description of changes:
Updated the latest framework versions for TensorFlow on Estimators and Models

Testing done:
All tests pass on py36 env when running tox tests/unit

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ChoiByungWook · 2021-03-17T17:57:55Z

src/sagemaker/fw_utils.py

@@ -59,7 +59,7 @@
    "local_gpu",
 )
 SM_DATAPARALLEL_SUPPORTED_FRAMEWORK_VERSIONS = {
-    "tensorflow": ["2.3.0", "2.3.1", "2.4.1"],
+    "tensorflow": ["2.3.1", "2.3.2", "2.4.1"],


Is this removing 2.3.0 as a valid version?

Correct. TF 2.3.0 images are not usable with SM DataParallel

sagemaker-bot · 2021-03-17T18:12:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 16cdc1d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-17T18:39:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 16cdc1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-17T18:43:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 16cdc1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-17T18:43:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 16cdc1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-17T18:45:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 16cdc1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tests/conftest.py

sagemaker-bot · 2021-03-17T22:22:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8db741f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-18T16:17:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 50e2ab6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-18T16:38:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 50e2ab6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-18T16:41:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 50e2ab6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-18T16:44:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 50e2ab6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-03-18T16:50:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 50e2ab6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* feature: update TF framework version support * Update 1.15 inference * Correct python versions * Fix test parametrization * Fix parametrization for major.minor versioning Co-authored-by: Ajay Karpur <[email protected]> Co-authored-by: Ahsan Khan <[email protected]>

saimidu added 2 commits March 17, 2021 10:25

feature: update TF framework version support

47ab5e5

Update 1.15 inference

16cdc1d

ChoiByungWook reviewed Mar 17, 2021

View reviewed changes

saimidu added 3 commits March 17, 2021 11:55

Correct python versions

f2764d3

Fix test parametrization

70d1e2e

Fix parametrization for major.minor versioning

34ad45c

ahsan-z-khan reviewed Mar 17, 2021

View reviewed changes

tests/conftest.py Show resolved Hide resolved

indhub mentioned this pull request Mar 17, 2021

Add SMDP support for TF 2.3.2 #2217

Closed

7 tasks

Merge branch 'master' into add_tf_fw_versions

8db741f

Merge branch 'master' into add_tf_fw_versions

50e2ab6

ajaykarpur approved these changes Mar 19, 2021

View reviewed changes

ajaykarpur merged commit a5ebdca into aws:master Mar 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feature: update TF framework version support #2223

feature: update TF framework version support #2223

Uh oh!

saimidu commented Mar 17, 2021 •

edited

Loading

Uh oh!

ChoiByungWook Mar 17, 2021

Uh oh!

saimidu Mar 17, 2021

Uh oh!

sagemaker-bot commented Mar 17, 2021

Uh oh!

sagemaker-bot commented Mar 17, 2021

Uh oh!

sagemaker-bot commented Mar 17, 2021

Uh oh!

sagemaker-bot commented Mar 17, 2021

Uh oh!

sagemaker-bot commented Mar 17, 2021

Uh oh!

Uh oh!

sagemaker-bot commented Mar 17, 2021

Uh oh!

sagemaker-bot commented Mar 18, 2021

Uh oh!

sagemaker-bot commented Mar 18, 2021

Uh oh!

sagemaker-bot commented Mar 18, 2021

Uh oh!

sagemaker-bot commented Mar 18, 2021

Uh oh!

sagemaker-bot commented Mar 18, 2021

Uh oh!

Uh oh!

feature: update TF framework version support #2223

feature: update TF framework version support #2223

Uh oh!

Conversation

saimidu commented Mar 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

ChoiByungWook Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

saimidu Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 17, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2021

AWS CodeBuild CI Report

Uh oh!

Uh oh!

sagemaker-bot commented Mar 17, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 18, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 18, 2021

AWS CodeBuild CI Report

Uh oh!

Uh oh!

saimidu commented Mar 17, 2021 •

edited

Loading