-
Notifications
You must be signed in to change notification settings - Fork 1.2k
change: Update BiasConfig to accept multiple facet params #2243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7c8beec
Update BiasConfig to accept multiple facet params
georschi 026c9ac
fix: typo in the file change
georschi 3ee71c7
fix: flake8 format enforcement
georschi 918fc1b
added unit tests for change in biasConfig
georschi d11246d
fix: update param type in docstring
georschi 1695db6
Merge branch 'master' into patch-1
georschi 18e322a
pylint fix to docstring length
georschi 0498077
Merge branch 'master' into patch-1
georschi 93f9ba9
Merge branch 'master' into patch-1
ahsan-z-khan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the type of this parameter now
str or [str]
, notAny
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right about this, but I changed to "Any" instead of "str or [str]" to be consistent with the way that this is defined for other parameters. For example on the line just above, label_values_or_threshold is of type Any when it could take a limited number of types.
I will be updating as suggested shortly