-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Disable Debugger When Checkpointing Is Enabled #2260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
NihalHarish
wants to merge
5
commits into
aws:master
from
NihalHarish:debug_disable_with_checkpointing
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
336475f
disable debugger when checkpointing is enabled
NihalHarish 347d6b2
refactor + add log + update test
NihalHarish dc67287
remove whitespace changes
NihalHarish ce002f4
lint
NihalHarish 28b4073
Merge branch 'master' into debug_disable_with_checkpointing
NihalHarish File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2219,7 +2219,14 @@ def _validate_and_set_debugger_configs(self): | |
): | ||
self.debugger_hook_config = DebuggerHookConfig(s3_output_path=self.output_path) | ||
elif not self.debugger_hook_config: | ||
self.debugger_hook_config = None | ||
self.debugger_hook_config = False | ||
|
||
# Disable debugger if checkpointing is enabled by the customer | ||
if self.checkpoint_s3_uri and self.checkpoint_local_path and self.debugger_hook_config: | ||
logger.info( | ||
"SM Debug Does Not Currently Support Training Jobs With Checkpointing Enabled" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Can you make this sentence case instead of capitalizing each word? |
||
) | ||
self.debugger_hook_config = False | ||
|
||
def _stage_user_code_in_s3(self): | ||
"""Upload the user training script to s3 and return the location. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.