Unify generation of model uploaded code location #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
==========================================
- Coverage 92.53% 91.51% -1.03%
==========================================
Files 49 45 -4
Lines 3257 3195 -62
==========================================
- Hits 3014 2924 -90
- Misses 243 271 +28
Continue to review full report at Codecov.
|
4 tasks
|
Rebased on the recently released 1.5.0 to update CHANGELOG and accommodate introduction of PyTorch |
- Extract repeated key_prefix calculation in different models (base, mxnet, tensorflow, chainer, pytorch) into a common utility method in fw_utils.py - The generated location now always respects the code_location prefix if present but it also concatenates either the model name or image-derived name to it - This is related to 2.b in #226
laurenyu
approved these changes
Jun 21, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Update eval frequency param for TensorBoard notebook for TensorFlow 1.6
nadiaya
pushed a commit
to nadiaya/sagemaker-python-sdk
that referenced
this pull request
Nov 25, 2019
Since Spark Processing jobs will not be available by GA, the relevant Spark Processor code has been removed for now.
knakad
pushed a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Dec 4, 2019
Since Spark Processing jobs will not be available by GA, the relevant Spark Processor code has been removed for now.
knakad
pushed a commit
that referenced
this pull request
Dec 4, 2019
Since Spark Processing jobs will not be available by GA, the relevant Spark Processor code has been removed for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 226 point 2.b
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.