Skip to content

Fix tensorboard thread after fitting #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2018
Merged

Fix tensorboard thread after fitting #229

merged 6 commits into from
Jun 20, 2018

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Jun 14, 2018

Issue #, if available:

Description of changes:
1, Fix unit tests
2, Join tensorboard thread when quit tensorboard

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested a review from iquintero June 14, 2018 04:40
@codecov-io
Copy link

Codecov Report

Merging #229 into master will increase coverage by 0.67%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   91.47%   92.14%   +0.67%     
==========================================
  Files          45       45              
  Lines        3166     3169       +3     
==========================================
+ Hits         2896     2920      +24     
+ Misses        270      249      -21
Impacted Files Coverage Δ
src/sagemaker/tensorflow/estimator.py 96.24% <100%> (+16.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72121b...41effb4. Read the comment docs.

@yangaws yangaws requested a review from winstonaws June 19, 2018 22:28
@yangaws yangaws merged commit 03b9849 into aws:master Jun 20, 2018
nadiaya pushed a commit to nadiaya/sagemaker-python-sdk that referenced this pull request Nov 25, 2019
This adds a list of training jobs to the Estimator.
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Dec 4, 2019
This adds a list of training jobs to the Estimator.
knakad pushed a commit that referenced this pull request Dec 4, 2019
This adds a list of training jobs to the Estimator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants