Update README running tests section #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify what's needed to run unit and integration tests
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 92.29% 92.35% +0.06%
==========================================
Files 49 49
Lines 3259 3259
==========================================
+ Hits 3008 3010 +2
+ Misses 251 249 -2
Continue to review full report at Codecov.
|
4 tasks
laurenyu
reviewed
Jun 21, 2018
README.rst
Outdated
| 1. Access to an AWS account to run the tests on | ||
| 2. Make the AWS account credentials available to boto3 clients used in the tests | ||
| 3. Ensure the AWS account has an IAM role named SageMakerRole | ||
| 4. Ensure the libraries mentioned in setup.py extra_require for test are installed |
There was a problem hiding this comment.
it might be clearer to include that running pip install --upgrade .[test] will install all the necessary libraries
laurenyu
approved these changes
Jun 21, 2018
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Added example notebook for SageMaker NTM on 20NewsGroups data set
knakad
pushed a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Nov 26, 2019
…pe is `multiclass_classifier` (aws#246)
knakad
pushed a commit
to knakad/sagemaker-python-sdk
that referenced
this pull request
Dec 4, 2019
…pe is `multiclass_classifier` (aws#246)
knakad
pushed a commit
that referenced
this pull request
Dec 4, 2019
…pe is `multiclass_classifier` (#246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify what's needed to run unit and integration tests
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.