Skip to content

Add documentation for using channels when training with TF #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2018

Conversation

laurenyu
Copy link
Contributor

Description of changes:
This functionality has been present for awhile, but was never documented in the README, so adding that with this change

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurenyu laurenyu requested a review from iquintero June 21, 2018 17:20
@codecov-io
Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #247 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   92.26%   92.29%   +0.03%     
==========================================
  Files          49       49              
  Lines        3259     3259              
==========================================
+ Hits         3007     3008       +1     
+ Misses        252      251       -1
Impacted Files Coverage Δ
src/sagemaker/amazon/common.py 96.26% <0%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f200e4...74a6b98. Read the comment docs.

@laurenyu laurenyu merged commit 15a736d into aws:master Jun 21, 2018
@laurenyu laurenyu deleted the document-tf-channels branch June 21, 2018 22:06
apacker pushed a commit to apacker/sagemaker-python-sdk that referenced this pull request Nov 15, 2018
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Nov 26, 2019
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Dec 4, 2019
knakad pushed a commit that referenced this pull request Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants