feature: support multiple facets for Clarify #2494

xiaoyi-cheng · 2021-06-29T17:11:24Z

Issue #, if available:

Description of changes:

Add facet_list to support multiple facets for Clarify
Add check and change doc for dataset_type

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2021-06-29T17:14:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3199943
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T17:48:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3199943
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T17:53:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3199943
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T17:54:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3199943
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T18:40:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3199943
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:16:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8a7168e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:41:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8a7168e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:42:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8a7168e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T20:47:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8a7168e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T21:35:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 550d972
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T21:58:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 550d972
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T22:07:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 550d972
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T22:09:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 550d972
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-29T22:15:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 550d972
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T06:18:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9028cb2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T06:44:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 9028cb2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T06:49:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9028cb2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T06:51:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 9028cb2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T06:59:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 9028cb2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T17:34:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bdb46af
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T17:59:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bdb46af
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T18:00:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bdb46af
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T18:07:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bdb46af
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T18:29:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: bdb46af
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

pinaraws · 2021-06-30T22:30:26Z

src/sagemaker/clarify.py

            facet_name (str): Sensitive attribute in the input data for which we like to compare
-                metrics.
+                metrics. Will be ignored if pass 'facet_list'.


Change to "Will be ignored if 'facet_list' is given"

pinaraws · 2021-06-30T22:30:40Z

src/sagemaker/clarify.py

@@ -89,20 +95,60 @@ def __init__(
            label_values_or_threshold (Any): List of label values or threshold to indicate positive
                outcome used for bias metrics.
            facet_name (str): Sensitive attribute in the input data for which we like to compare
-                metrics.
+                metrics. Will be ignored if pass 'facet_list'.
            facet_values_or_threshold (list): Optional list of values to form a sensitive group or
                threshold for a numeric facet column that defines the lower bound of a sensitive
                group. Defaults to considering each possible value as sensitive group and
                computing metrics vs all the other examples.


Add here: "Will be ignored if 'facet_list' is given"

sagemaker-bot · 2021-06-30T23:04:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b72c5d3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T23:30:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b72c5d3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T23:33:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b72c5d3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T23:37:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b72c5d3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-06-30T23:41:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b72c5d3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-01T19:11:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8f93067
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-01T19:41:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8f93067
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-01T19:41:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8f93067
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-01T19:45:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8f93067
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-01T20:08:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8f93067
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

xiaoyi-cheng · 2021-07-08T20:32:17Z

Decide to go with this approach. Close the PR.

xiaoyi-cheng force-pushed the jobNamePrefix branch from 3199943 to 8a7168e Compare June 29, 2021 20:04

xiaoyi-cheng force-pushed the jobNamePrefix branch from 550d972 to 9028cb2 Compare June 30, 2021 06:07

xiaoyi-cheng force-pushed the jobNamePrefix branch from 9028cb2 to bdb46af Compare June 30, 2021 17:22

pinaraws reviewed Jun 30, 2021

View reviewed changes

xiaoyi-cheng added 2 commits June 30, 2021 15:53

feature: support multiple facets for Clarify

511bb7d

fix: minor

11fbf9a

xiaoyi-cheng added 2 commits June 30, 2021 15:53

fix: minor

09fec3d

documentation: required fix

b72c5d3

xiaoyi-cheng force-pushed the jobNamePrefix branch from bdb46af to b72c5d3 Compare June 30, 2021 22:53

pinaraws approved these changes Jul 1, 2021

View reviewed changes

Merge branch 'master' into jobNamePrefix

8f93067

xiaoyi-cheng closed this Jul 8, 2021

xiaoyi-cheng deleted the jobNamePrefix branch July 8, 2021 20:32

feature: support multiple facets for Clarify #2494

feature: support multiple facets for Clarify #2494

Uh oh!

Conversation

xiaoyi-cheng commented Jun 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2021

xiaoyi-cheng commented Jun 29, 2021 •

edited

Loading