fix: set sagemaker_connection and image_uri in register method #2526

iasoon · 2021-07-20T16:14:51Z

Issue #, if available:

Description of changes:
Provide a register method for the sklearn model, since without it the sagemaker_connection and image_uri variables are not being set, which results in an error when running this minimal code example:

    model = SKLearnModel(
        framework_version="0.23-1",
        py_version="py3",
        model_data=MODEL_DATA
        entry_point="serve.py",
        source_dir="./model",
        role=ROLE,
    )

    model.register(
        model_package_name=MODEL_PACKAGE_NAME,
        content_types=["text/csv"],
        response_types=["text/csv"],
        inference_instances=["ml.t2.medium"],
        transform_instances=["ml.m5.large"],

I adapted the register method from the other FrameworkModels to resolve the issue.
That said, it seems like the register code is the same for all FrameworkModels, except for the XGBoostModel (though the logic seems equivalent at first sight). Would it be a good idea to extract this duplication into the FrameworkModel class?

Testing done:
code snippet above

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2021-07-20T16:17:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 16b3f0e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T16:51:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 16b3f0e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T16:53:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 16b3f0e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T16:54:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 16b3f0e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T17:00:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 16b3f0e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T21:27:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7eeb10f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T21:55:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7eeb10f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T22:00:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7eeb10f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T22:01:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7eeb10f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-07-20T22:10:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7eeb10f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

iasoon · 2021-07-21T07:33:13Z

Is it possible that there is something off about the failing test (tests/integ/test_mxnet.py::test_deploy_model[1.8.0-py37-1.8.0-py37])? It passed on the first run, but failed after I added an empty line.

ahsan-z-khan · 2021-08-10T21:36:01Z

@iasoon is there any particular issue/feature request for this PR?

sagemaker-bot · 2021-08-10T21:46:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 71b39df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-10T22:08:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 71b39df
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-10T22:11:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 71b39df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-10T22:20:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 71b39df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2021-08-11T00:06:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 71b39df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

iasoon · 2021-08-12T11:08:00Z

@ahsan-z-khan No, I just created this PR after running into the issue described in the original post.

sagemaker-bot · 2022-01-14T00:45:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 71b39df
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan · 2022-01-24T18:54:09Z

@iasoon do we have an issue created for this PR?

iasoon · 2022-01-24T22:38:37Z

Hey @ahsan-z-khan , I didn't create one myself, but #2696 seems to be about the same bug.

sagemaker-bot · 2022-02-03T01:16:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8944f7d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-02-03T01:50:03Z

Codecov Report

Merging #2526 (8944f7d) into dev (90b0b0f) will decrease coverage by 0.03%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##              dev    #2526      +/-   ##
==========================================
- Coverage   89.08%   89.04%   -0.04%     
==========================================
  Files         182      182              
  Lines       15945    15953       +8     
==========================================
+ Hits        14205    14206       +1     
- Misses       1740     1747       +7

Impacted Files	Coverage Δ
src/sagemaker/sklearn/model.py	`81.63% <12.50%> (-13.49%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b0b0f...8944f7d. Read the comment docs.

sagemaker-bot · 2022-02-03T01:55:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8944f7d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T02:08:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8944f7d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-02-03T02:23:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8944f7d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

fix: set sagemaker_connection and image_uri in register method

16b3f0e

code: formatting

7eeb10f

Merge branch 'master' into master

71b39df

ahsan-z-khan added the type: feature request label Aug 10, 2021

ahsan-z-khan changed the base branch from master to dev December 21, 2021 01:16

mufaddal-rohawala force-pushed the dev branch from beeabbd to b026769 Compare January 4, 2022 17:09

shreyapandit force-pushed the dev branch from 1c039c8 to 7206b9e Compare January 10, 2022 23:05

shreyapandit force-pushed the dev branch from 903205c to b796a00 Compare January 18, 2022 20:09

BasilBeirouti force-pushed the dev branch from 814dd3d to 70308b1 Compare January 24, 2022 20:10

jeniyat force-pushed the dev branch 3 times, most recently from f5e6849 to 34b07c0 Compare January 29, 2022 23:28

Merge branch 'dev' into master

8944f7d

mufaddal-rohawala approved these changes Feb 3, 2022

View reviewed changes

ahsan-z-khan approved these changes Feb 3, 2022

View reviewed changes

ahsan-z-khan merged commit 4886405 into aws:dev Feb 3, 2022

mufaddal-rohawala added a commit that referenced this pull request Feb 3, 2022

fix: set sagemaker_connection and image_uri in register method (#2526)

6a3790a

Co-authored-by: Ahsan Khan <[email protected]> Co-authored-by: Mufaddal Rohawala <[email protected]>

lorenzwalthert mentioned this pull request Sep 26, 2023

model.register() not working for SKLearn Framework #2696

Closed

fix: set sagemaker_connection and image_uri in register method #2526

fix: set sagemaker_connection and image_uri in register method #2526

Uh oh!

Conversation

iasoon commented Jul 20, 2021

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 20, 2021

AWS CodeBuild CI Report

Uh oh!

iasoon commented Jul 21, 2021

Uh oh!

ahsan-z-khan commented Aug 10, 2021

Uh oh!

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 10, 2021

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 11, 2021

AWS CodeBuild CI Report

Uh oh!

iasoon commented Aug 12, 2021

Uh oh!

sagemaker-bot commented Jan 14, 2022

AWS CodeBuild CI Report

Uh oh!

ahsan-z-khan commented Jan 24, 2022

Uh oh!

iasoon commented Jan 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Feb 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 3, 2022

AWS CodeBuild CI Report

iasoon commented Jan 24, 2022 •

edited

Loading

codecov-commenter commented Feb 3, 2022 •

edited

Loading