-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add tags on endpoints #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 92.27% 92.27% +<.01%
==========================================
Files 49 49
Lines 3261 3264 +3
==========================================
+ Hits 3009 3012 +3
Misses 252 252
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
the integ tests are failing with this error:
Can you modify your change to not pass along |
d3eadbd
to
d9697b4
Compare
Hey @laurenyu , I fixed it :-) |
src/sagemaker/session.py
Outdated
EndpointConfigName=name, ProductionVariants=production_variants, Tags=tags) | ||
else: | ||
self.sagemaker_client.create_endpoint_config( | ||
EndpointConfigName=name, ProductionVariants=production_variants) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think of doing it this way?
config_options = {'EndpointConfigName': name, 'ProductionVariants': production_variants}
if tags:
config_options['Tags'] = tags
self.sagemaker_client.create_endpoint_config(**config_options)
d9697b4
to
3e24528
Compare
@laurenyu great idea. Done! |
Fixed: pip install pandas in container
* Add get_rule_container_image_uri and rename container_local_path parameter * Fix bug with merging rule parameters * Remove syntax incompatible with Python 2.7 * Add more detail to RuntimeError message * Remove rule evaluator ECR repo from mapping * Do not pass instance type and volume size for 1P rules * Default CollectionConfig.parameters to None * Temporarily comment out Debugger integ tests until API changes are in Prod * Fix linting violations * Fix unit tests to account for changes in S3OutputPath * Minor change to trigger a new build * Remove sagemaker_gamma_session * Remove instance type and volume size from Sagemaker.rule classmethod * Add fixtures to test_processing to fix cross-region errors
* Add get_rule_container_image_uri and rename container_local_path parameter * Fix bug with merging rule parameters * Remove syntax incompatible with Python 2.7 * Add more detail to RuntimeError message * Remove rule evaluator ECR repo from mapping * Do not pass instance type and volume size for 1P rules * Default CollectionConfig.parameters to None * Temporarily comment out Debugger integ tests until API changes are in Prod * Fix linting violations * Fix unit tests to account for changes in S3OutputPath * Minor change to trigger a new build * Remove sagemaker_gamma_session * Remove instance type and volume size from Sagemaker.rule classmethod * Add fixtures to test_processing to fix cross-region errors
* Add get_rule_container_image_uri and rename container_local_path parameter * Fix bug with merging rule parameters * Remove syntax incompatible with Python 2.7 * Add more detail to RuntimeError message * Remove rule evaluator ECR repo from mapping * Do not pass instance type and volume size for 1P rules * Default CollectionConfig.parameters to None * Temporarily comment out Debugger integ tests until API changes are in Prod * Fix linting violations * Fix unit tests to account for changes in S3OutputPath * Minor change to trigger a new build * Remove sagemaker_gamma_session * Remove instance type and volume size from Sagemaker.rule classmethod * Add fixtures to test_processing to fix cross-region errors
Issue #, if available:
Description of changes:
Option to add Tags on SageMaker Endpoints. I'd like this option so that to tag endpoints for auditing and linking IDs of trained models to endpoints. The latter is very important because I can know which models are dpeloyed in production.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.