Skip to content

Fix links in KMeans docstring #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Conversation

laurenyu
Copy link
Contributor

Description of changes:
We have a couple incorrect links, and one that never got filled in.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurenyu laurenyu requested a review from iquintero June 25, 2018 20:56
@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

Merging #254 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   92.34%   92.58%   +0.24%     
==========================================
  Files          49       49              
  Lines        3277     3277              
==========================================
+ Hits         3026     3034       +8     
+ Misses        251      243       -8
Impacted Files Coverage Δ
src/sagemaker/amazon/kmeans.py 100% <ø> (ø) ⬆️
src/sagemaker/local/image.py 88.56% <0%> (+2.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e4c545...65011d2. Read the comment docs.

@laurenyu laurenyu merged commit 0efeacf into aws:master Jun 26, 2018
@laurenyu laurenyu deleted the remove-alpha-doc-links branch June 26, 2018 15:48
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Nov 27, 2019
Add the enable_sagemaker_metrics flag for Estimators. This corresponds to the new EnableSageMakerMetricsTimeSeries parameter.

By default, if the flag is unset then we don't pass on the EnableSageMakerMetricsTimeSeries parameter unless you're using the following framework versions:

MXNet >= 1.6
TensorFlow >=1.15
Pytorch >=1.3
knakad pushed a commit to knakad/sagemaker-python-sdk that referenced this pull request Dec 4, 2019
Add the enable_sagemaker_metrics flag for Estimators. This corresponds to the new EnableSageMakerMetricsTimeSeries parameter.

By default, if the flag is unset then we don't pass on the EnableSageMakerMetricsTimeSeries parameter unless you're using the following framework versions:

MXNet >= 1.6
TensorFlow >=1.15
Pytorch >=1.3
knakad pushed a commit that referenced this pull request Dec 4, 2019
Add the enable_sagemaker_metrics flag for Estimators. This corresponds to the new EnableSageMakerMetricsTimeSeries parameter.

By default, if the flag is unset then we don't pass on the EnableSageMakerMetricsTimeSeries parameter unless you're using the following framework versions:

MXNet >= 1.6
TensorFlow >=1.15
Pytorch >=1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants