Skip to content

fix: notebook test for parallel PRs #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2021
Merged

fix: notebook test for parallel PRs #2691

merged 3 commits into from
Oct 9, 2021

Conversation

jeniyat
Copy link
Contributor

@jeniyat jeniyat commented Oct 8, 2021

Issue #, if available:
the .tar.gz file is currently overwritten whenever there are parallel PRs. This causes inconsistent results.

Description of changes:
Files changed: tests/scripts/run-notebook-test.sh

  • Modified .tar.gz file name. Now the file name contains commit-id and account-id.
  • Create new life cycle configuration for each commit, and the life cycle configuration name has the commit-id and account-id. So the resources used in parallel PR will be different.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: d07f5ec
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: e772967
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jeniyat jeniyat changed the title fix: resolve tar.gz over write at notebook test for parallel PR fix: resolve tar.gz overwrite inside notebook test for parallel PR Oct 8, 2021
@ahsan-z-khan ahsan-z-khan changed the title fix: resolve tar.gz overwrite inside notebook test for parallel PR fix: notebook test for parallel PRs Oct 8, 2021
@jeniyat jeniyat merged commit 529256d into aws:master Oct 9, 2021
@jeniyat jeniyat deleted the fix_notebook_test branch October 9, 2021 07:53
EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants