Add Chainer 4.1.0 #278
Merged
Add Chainer 4.1.0 #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Chainer 4.1.0 to README * Use Chainer 4.1.0 as default Chainer version * Use fixture chainer_full_version for Chainer integ tests * Bump sdk version to 1.6.0 * Modify CHANGELOG
mvsusp
suggested changes
Jul 6, 2018
CHANGELOG.rst
Outdated
| ===== | ||
| * feature: Add Chainer 4.1.0 support | ||
| * bug-fix: Use chainer_full_version fixture in Chainer integration tests | ||
|
|
||
| 1.5.3dev | ||
| ======== |
There was a problem hiding this comment.
Please remove the suffix dev from here.
|
Good point about the necessity of running both versions for some of the tests. I will keep both versions only for the training related tests. |
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=========================================
- Coverage 92.46% 92.4% -0.07%
=========================================
Files 49 49
Lines 3303 3303
=========================================
- Hits 3054 3052 -2
- Misses 249 251 +2
Continue to review full report at Codecov.
|
mvsusp
previously approved these changes
Jul 9, 2018
andremoeller
previously approved these changes
Jul 9, 2018
yangaws
approved these changes
Jul 11, 2018
| ===== | ||
|
|
||
| * feature: Add Chainer 4.1.0 support | ||
| * bug-fix: Use chainer_full_version fixture in Chainer integration tests |
There was a problem hiding this comment.
I don't think we add test related changes in change log.
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
Fixed: HPO Analyze Results notebook to catch running before a best job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.