Skip to content

fix: Recreate static lineage test data #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2021
Merged

fix: Recreate static lineage test data #2782

merged 1 commit into from
Dec 3, 2021

Conversation

staubhp
Copy link
Contributor

@staubhp staubhp commented Dec 3, 2021

Issue #, if available:

Description of changes:
Lineage tests are failing here:

    def test_endpoint_contexts(
        static_model_artifact,
        sagemaker_session,
    ):
        contexts_from_query = static_model_artifact.endpoint_contexts()
    
        associations_from_api = traverse_graph_forward(
            static_model_artifact.artifact_arn, sagemaker_session=sagemaker_session
        )
    
>       assert len(contexts_from_query) > 0
E       assert 0 > 0
E        +  where 0 = len([])

tests/integ/sagemaker/lineage/test_model_artifact.py:43: AssertionError

Recreate the test data to see if this is transient.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 663e02e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shreyapandit shreyapandit merged commit dcb46e1 into aws:master Dec 3, 2021
BasilBeirouti pushed a commit that referenced this pull request Dec 6, 2021
EthanShouhanCheng pushed a commit to SissiChenxy/sagemaker-python-sdk that referenced this pull request Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants