feature: Add support for TF 2.8 #3000

saimidu · 2022-03-16T00:28:26Z

Issue #, if available:

Description of changes:
Add support for TF 2.7 and TF 2.8 framework versions and smdataparallel to sagemaker-python-sdk

Testing done:
Ran unit tests on py36 and py37.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-commenter · 2022-03-16T00:44:55Z

Codecov Report

Merging #3000 (f937db6) into master (d52b8a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3000   +/-   ##
=======================================
  Coverage   89.89%   89.89%           
=======================================
  Files         196      196           
  Lines       16610    16610           
=======================================
  Hits        14932    14932           
  Misses       1678     1678

Impacted Files	Coverage Δ
src/sagemaker/fw_utils.py	`90.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d52b8a9...f937db6. Read the comment docs.

sagemaker-bot · 2022-03-16T00:54:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: af57e4e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/image_uri_config/tensorflow.json

sagemaker-bot · 2022-03-16T01:46:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: af57e4e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T02:03:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: af57e4e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

saimidu · 2022-03-16T02:19:43Z

@mufaddal-rohawala @jeniyat Not sure what went wrong with the sagemaker-python-sdk-pr job. Could you take a look?

jeniyat

LGTM

…_tf_2.7_2.8

sagemaker-bot · 2022-03-16T08:15:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 966ec44
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T08:16:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e5eefa9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T09:12:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 966ec44
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T09:12:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e5eefa9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T10:03:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e5eefa9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T10:03:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 966ec44
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-16T18:07:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e5eefa9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

ahsan-z-khan

Can you only add TF2.8 in this PR? TF2.7 is being added here: #2958

Also, it helps us to keep track of what has been added in which PR

…_tf_2.7_2.8

saimidu · 2022-03-17T04:36:22Z

I'd still like to contribute updates on the older framework versions, such as TF 2.4.3 and TF 2.6.2. Should I pull those out into a separate PR as well?

sagemaker-bot · 2022-03-17T05:01:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e155619
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T05:01:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 56c39f9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T05:34:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: e155619
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T05:39:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 56c39f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T05:46:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: e155619
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T05:54:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 56c39f9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T09:03:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 56c39f9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T20:30:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f6553ba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T21:30:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f6553ba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-17T21:40:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f6553ba
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T00:26:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4a3049d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T00:56:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4a3049d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…_tf_2.7_2.8

sagemaker-bot · 2022-03-18T01:32:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f937db6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T01:48:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4a3049d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T02:10:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f937db6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-18T02:28:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f937db6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* feature: Add support for TF 2.7 and TF 2.8 * Correct TF 2.7 patch version used in tests * Correct TF 2.7 patch version for SMDDP TF versions * Only add entries for TF 2.8 * Fix test options for TF 2.8 for fw_utils * Update tensorflow.json Co-authored-by: Mufaddal Rohawala <[email protected]>

feature: Add support for TF 2.7 and TF 2.8

af57e4e

mufaddal-rohawala reviewed Mar 16, 2022

View reviewed changes

src/sagemaker/image_uri_config/tensorflow.json Outdated Show resolved Hide resolved

mufaddal-rohawala requested a review from jeniyat March 16, 2022 00:57

jeniyat approved these changes Mar 16, 2022

View reviewed changes

saimidu added 3 commits March 16, 2022 00:55

Correct TF 2.7 patch version used in tests

9a7ced6

Merge branch 'master' of github.com:aws/sagemaker-python-sdk into add…

966ec44

…_tf_2.7_2.8

Correct TF 2.7 patch version for SMDDP TF versions

e5eefa9

ahsan-z-khan suggested changes Mar 16, 2022

View reviewed changes

Merge branch 'master' of github.com:aws/sagemaker-python-sdk into add…

a65d3f5

…_tf_2.7_2.8

saimidu added 2 commits March 16, 2022 21:36

Only add entries for TF 2.8

e155619

Fix test options for TF 2.8 for fw_utils

56c39f9

saimidu changed the title ~~feature: Add support for TF 2.7 and TF 2.8~~ feature: Add support for TF 2.8 Mar 17, 2022

Update tensorflow.json

f6553ba

mufaddal-rohawala approved these changes Mar 17, 2022

View reviewed changes

saimidu requested a review from ahsan-z-khan March 17, 2022 22:19

ahsan-z-khan approved these changes Mar 18, 2022

View reviewed changes

Merge branch 'master' into add_tf_2.7_2.8

4a3049d

saimidu added 2 commits March 17, 2022 18:06

Merge branch 'master' of github.com:aws/sagemaker-python-sdk into add…

116f059

…_tf_2.7_2.8

Fix trailing comma

f937db6

jeniyat merged commit 2eace35 into aws:master Mar 18, 2022

saimidu deleted the add_tf_2.7_2.8 branch March 18, 2022 17:10

feature: Add support for TF 2.8 #3000

feature: Add support for TF 2.8 #3000

Uh oh!

Conversation

saimidu commented Mar 16, 2022

Merge Checklist

General

Tests

Uh oh!

codecov-commenter commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

saimidu commented Mar 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jeniyat left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 16, 2022

AWS CodeBuild CI Report

Uh oh!

ahsan-z-khan left a comment

Choose a reason for hiding this comment

Uh oh!

saimidu commented Mar 17, 2022

Uh oh!

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 17, 2022

codecov-commenter commented Mar 16, 2022 •

edited

Loading

saimidu commented Mar 16, 2022 •

edited

Loading