feature: Retrieve data configuration #3016

shreyapandit · 2022-03-22T02:29:01Z

Description of changes:
Add APIs to allow retrieval of data configuration for Example Notebooks.

Testing done:
Added unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license

sagemaker-bot · 2022-03-22T02:39:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f437783
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T03:31:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f437783
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T03:49:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f437783
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-03-22T05:02:23Z

Codecov Report

Merging #3016 (7b54c3e) into master (b0f2b4a) will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #3016      +/-   ##
==========================================
+ Coverage   89.32%   89.33%   +0.01%     
==========================================
  Files         196      196              
  Lines       16622    16641      +19     
==========================================
+ Hits        14848    14867      +19     
  Misses       1774     1774

Impacted Files	Coverage Δ
src/sagemaker/utils.py	`92.50% <94.73%> (+0.19%)`	⬆️
src/sagemaker/session.py	`70.47% <0.00%> (+0.07%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0f2b4a...7b54c3e. Read the comment docs.

sagemaker-bot · 2022-03-22T05:09:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b1f9298
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T05:48:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b1f9298
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T06:59:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b1f9298
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/utils.py

sagemaker-bot · 2022-03-22T21:40:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 94167fc
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T21:54:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5fbe817
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T22:44:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5fbe817
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T22:44:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 94167fc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T22:54:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0d34dc9
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T23:08:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 94167fc
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T23:28:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0d34dc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-22T23:32:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0d34dc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/utils.py

sagemaker-bot · 2022-03-25T01:24:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4738657
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-25T01:44:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4738657
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-25T02:35:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: db697db
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-25T02:42:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: db697db
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-25T03:31:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: db697db
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T00:54:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 030caa7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T01:08:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 030caa7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/utils.py

sagemaker-bot · 2022-03-26T01:22:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7de0d09
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T01:33:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0fbe67f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T01:36:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7b54c3e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T01:58:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7de0d09
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T02:11:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0fbe67f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T02:11:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7b54c3e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T02:37:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7b54c3e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T02:47:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7b54c3e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T02:47:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0fbe67f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T02:47:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7de0d09
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-03-26T02:56:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 030caa7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shreyapandit changed the title ~~change: update code to get commit_id in codepipeline (#2961)~~ feature: Retrieve data configuration for Example Notebooks Mar 22, 2022

shreyapandit requested review from mufaddal-rohawala and navinsoni March 22, 2022 06:06

navinsoni suggested changes Mar 22, 2022

View reviewed changes

src/sagemaker/utils.py Outdated Show resolved Hide resolved

src/sagemaker/utils.py Outdated Show resolved Hide resolved

src/sagemaker/utils.py Outdated Show resolved Hide resolved

src/sagemaker/utils.py Outdated Show resolved Hide resolved

navinsoni reviewed Mar 24, 2022

View reviewed changes

src/sagemaker/utils.py Outdated Show resolved Hide resolved

shreyapandit added 4 commits March 25, 2022 18:05

Add method to retrieve Notebooks data config from S3

c6582d9

minor formatting and cosmetic updates

15218fd

Update to take params as input

ca13158

Refresh docstrings

00439b8

shreyapandit added 4 commits March 25, 2022 18:05

remove extra line

4fd639d

Send everything through arguments

666664f

Update docstrings

b5bf622

Update doctsrings to match

0fbe67f

shreyapandit closed this Mar 26, 2022

shreyapandit reopened this Mar 26, 2022

shreyapandit force-pushed the add_notebooks_data_config branch from 7de0d09 to 0fbe67f Compare March 26, 2022 01:12

navinsoni reviewed Mar 26, 2022

View reviewed changes

src/sagemaker/utils.py Outdated Show resolved Hide resolved

correct docstrings

7b54c3e

navinsoni approved these changes Mar 26, 2022

View reviewed changes

navinsoni changed the title ~~feature: Retrieve data configuration for Example Notebooks~~ feature: Retrieve data configuration Mar 26, 2022

navinsoni merged commit 46684a7 into aws:master Mar 26, 2022

jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022

feature: Retrieve data configuration (aws#3016)

a4dc2f2

feature: Retrieve data configuration #3016

feature: Retrieve data configuration #3016

Uh oh!

Conversation

shreyapandit commented Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Mar 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 22, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

sagemaker-bot commented Mar 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 26, 2022

shreyapandit commented Mar 22, 2022 •

edited

Loading

codecov-commenter commented Mar 22, 2022 •

edited

Loading