Skip to content

fix: Refactor repack_model script injection, fixes tar.gz error #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

staubhp
Copy link
Contributor

@staubhp staubhp commented Mar 31, 2022

…gz error

Issue #, if available:
3038

Description of changes:
Repack model injection is not working for S3 source directories. Refactor this to follow logic similar to Model's repack method.

Testing done:
Manual, unit

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@staubhp staubhp requested review from danabens and navinsoni March 31, 2022 17:22
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6b517c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6b517c5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #3039 (6b517c5) into master (8e0a37f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3039      +/-   ##
==========================================
+ Coverage   89.33%   89.39%   +0.05%     
==========================================
  Files         196      196              
  Lines       16649    16650       +1     
==========================================
+ Hits        14874    14884      +10     
+ Misses       1775     1766       -9     
Impacted Files Coverage Δ
src/sagemaker/workflow/_utils.py 95.83% <100.00%> (+8.43%) ⬆️
src/sagemaker/session.py 70.44% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0a37f...6b517c5. Read the comment docs.

@mufaddal-rohawala mufaddal-rohawala changed the title fix: Refactor repack_model script injection to avoid IsADirectory tar… fix: Refactor repack_model script injection, fixes tar.gz error Mar 31, 2022
@mufaddal-rohawala mufaddal-rohawala merged commit 5d8ebfc into aws:master Mar 31, 2022
jerrypeng7773 pushed a commit to jerrypeng7773/sagemaker-python-sdk that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants