fix: jumpstart amt tracking #3077

evakravi · 2022-04-22T19:27:58Z

Issue #, if available:

Description of changes:
Hyperparameter Tuning jobs launched with JumpStart artifacts (scripts, model) will be tagged with the artifact uris and the base name will also be modified to "sagemaker-jumpstart".

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-04-22T19:46:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 122d5a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-22T20:05:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 122d5a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-04-22T20:05:54Z

Codecov Report

Merging #3077 (21a5357) into master (c53bbbc) will decrease coverage by 0.07%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #3077      +/-   ##
==========================================
- Coverage   89.71%   89.63%   -0.08%     
==========================================
  Files        1048      200     -848     
  Lines       87496    17342   -70154     
==========================================
- Hits        78493    15545   -62948     
+ Misses       9003     1797    -7206

Impacted Files	Coverage Δ
src/sagemaker/tuner.py	`97.98% <94.44%> (-0.15%)`	⬇️
src/sagemaker/session.py	`70.97% <0.00%> (-0.08%)`	⬇️
...e-packages/sagemaker/debugger/framework_profile.py
...on3.6/site-packages/sagemaker/chainer/estimator.py
...ib/python3.8/site-packages/sagemaker/amazon/lda.py
...8/site-packages/sagemaker/huggingface/estimator.py
...thon3.8/site-packages/sagemaker/jumpstart/types.py
...te-packages/sagemaker/workflow/check_job_config.py
...thon3.7/site-packages/sagemaker/apiutils/_utils.py
...-packages/sagemaker/workflow/parallelism_config.py
... and 840 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53bbbc...21a5357. Read the comment docs.

sagemaker-bot · 2022-04-22T20:16:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 122d5a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-22T20:16:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 122d5a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-22T20:23:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 122d5a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-22T20:33:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 122d5a7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-22T20:52:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 122d5a7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

JGuinegagne

This looks good overall, would you mind expanding the unit test coverage?

src/sagemaker/tuner.py

tests/unit/test_tuner.py

sagemaker-bot · 2022-04-25T14:26:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a00de67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-25T14:42:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a00de67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-25T14:53:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a00de67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-25T15:11:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a00de67
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-25T15:18:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a00de67
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-04-25T20:26:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a00de67
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

GiannisMitr

Please test the deploy method. If you check the code for method "deploy" of Estimator, it invokes a method to update the tags with JS tags. I am not sure if you also need to add that, since tuner.deploy() invoked estimator.deploy() that invokes this method.

sagemaker-bot · 2022-05-02T20:46:16Z

src/sagemaker/tuner.py

+
+        estimator_tags = getattr(estimator, "tags", []) or []
+
+        if self.tags is None and len(estimator_tags) > 0:


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

To check if a container or sequence (string, list, tuple) is empty, use if not val. Do not compare its length using if len(val) == 0 or if len(val) > 0

Learn more

Sorry, I disagree with this suggestion. Because python has no type checking, if not val can resolve differently and unexpectedly when val is a boolean, string, or list type. By explicitly writing len(estimator_tags) > 0, it's easier for the reader to understand that this is a list that has nothing in it.

sagemaker-bot · 2022-05-02T21:01:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 29ee04a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-02T21:16:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 29ee04a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-02T21:32:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 29ee04a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-02T21:47:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 29ee04a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-02T23:35:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 29ee04a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

GiannisMitr · 2022-05-03T12:23:53Z

Please check/rerun the sagemaker-python-sdk-pr and sagemaker-python-sdk-slow-tests currently failing. It seems there are transient Failures. Thanks

sagemaker-bot · 2022-05-19T16:32:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 383b2d6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T16:39:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 383b2d6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T16:59:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 383b2d6
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T18:46:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 383b2d6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-19T18:47:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 383b2d6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T15:42:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ab7a60e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T15:54:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ab7a60e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T16:01:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ab7a60e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T16:22:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ab7a60e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T16:22:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ab7a60e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-20T18:32:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ab7a60e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-24T21:59:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ab7a60e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-24T23:39:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: eef2ed7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-24T23:54:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: eef2ed7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T00:04:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: eef2ed7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T00:21:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: eef2ed7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T00:23:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: eef2ed7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T13:09:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 21a5357
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T13:23:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 21a5357
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T13:35:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 21a5357
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T13:51:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 21a5357
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T15:38:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 21a5357
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

navinsoni · 2022-05-25T16:29:47Z

src/sagemaker/tuner.py

+        """Add tags to tuning job (from Estimator and JumpStart tags)."""
+
+        # Add tags from Estimator class
+        estimator = self.estimator or self.estimator_dict[sorted(self.estimator_dict.keys())[0]]


will 'estimator_dict' always have a value

It should always have a value. I used the same code as here:

sagemaker-python-sdk/src/sagemaker/tuner.py

Line 330 in 8d84618

self.estimator or self.estimator_dict[sorted(self.estimator_dict.keys())[0]]

sagemaker-bot · 2022-05-25T17:18:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 21a5357
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-05-25T19:21:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 21a5357
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

fix: jumpstart amt tracking

122d5a7

evakravi marked this pull request as draft April 22, 2022 19:28

JGuinegagne requested changes Apr 22, 2022

View reviewed changes

src/sagemaker/tuner.py Outdated Show resolved Hide resolved

src/sagemaker/tuner.py Outdated Show resolved Hide resolved

src/sagemaker/tuner.py Show resolved Hide resolved

tests/unit/test_tuner.py Show resolved Hide resolved

chore: address git comments

a00de67

evakravi marked this pull request as ready for review April 25, 2022 14:07

JGuinegagne approved these changes Apr 25, 2022

View reviewed changes

GiannisMitr reviewed Apr 26, 2022

View reviewed changes

chore: add unit test for deploying jumpstart amt model

29ee04a

sagemaker-bot reviewed May 2, 2022

View reviewed changes

GiannisMitr approved these changes May 3, 2022

View reviewed changes

Merge branch 'master' into fix/jumpstart-amt-tracking

ab7a60e

Merge branch 'master' into fix/jumpstart-amt-tracking

eef2ed7

Merge branch 'master' into fix/jumpstart-amt-tracking

21a5357

navinsoni reviewed May 25, 2022

View reviewed changes

navinsoni approved these changes May 25, 2022

View reviewed changes

navinsoni merged commit ef986c5 into aws:master May 25, 2022


		estimator_tags = getattr(estimator, "tags", []) or []

		if self.tags is None and len(estimator_tags) > 0:

fix: jumpstart amt tracking #3077

fix: jumpstart amt tracking #3077

Uh oh!

Conversation

evakravi commented Apr 22, 2022

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Apr 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 22, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Apr 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Apr 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 22, 2022

AWS CodeBuild CI Report

Uh oh!

JGuinegagne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Apr 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 25, 2022

AWS CodeBuild CI Report

Uh oh!

GiannisMitr left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot May 2, 2022

Choose a reason for hiding this comment

Uh oh!

mufaddal-rohawala May 13, 2022

Choose a reason for hiding this comment

Uh oh!

evakravi May 25, 2022

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented May 2, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 2, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 2, 2022

AWS CodeBuild CI Report

codecov-commenter commented Apr 22, 2022 •

edited

Loading

GiannisMitr left a comment •

edited

Loading

GiannisMitr commented May 3, 2022 •

edited

Loading