Skip to content

feature: Add support for TF2.9.2 training images #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 14, 2022
Merged

feature: Add support for TF2.9.2 training images #3178

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e2b4dae
support TF2.9.1 inference images
tejaschumbalkar Jun 17, 2022
bb3f710
Merge branch 'master' into support_tf2.9_inference
tejaschumbalkar Jun 18, 2022
e3ac2c4
update patch version
tejaschumbalkar Jun 20, 2022
8a70282
Merge branch 'support_tf2.9_inference' of https://github.com/tejaschu…
tejaschumbalkar Jun 20, 2022
50ed92e
support TF2.9.1 inference images
tejaschumbalkar Jun 17, 2022
7c544a3
update patch version
tejaschumbalkar Jun 20, 2022
91ae4a9
Merge branch 'support_tf2.9_inference' of https://github.com/tejaschu…
tejaschumbalkar Dec 5, 2022
2995a63
upgrade version to v2.9.2
tejaschumbalkar Dec 5, 2022
a43a71b
Merge remote-tracking branch 'upstream/master' into support_tf2.9_inf…
tejaschumbalkar Dec 6, 2022
dd2bc49
Merge branch 'master' into support_tf2.9_inference
tejaschumbalkar Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion src/sagemaker/image_uri_config/tensorflow.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,8 @@
"2.5": "2.5.1",
"2.6": "2.6.3",
"2.7": "2.7.0",
"2.8": "2.8.0"
"2.8": "2.8.0",
"2.9": "2.9.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tejaschumbalkar training does not have a 2.9.0 image but a 2.9.1 image here. This causes the tests based on tf_full_version to fail. We have 2 options:

  1. Can we switch to consistent TF Version for inference 2.9.1?
  2. Fix the failing tests, current logic is that it tries to get a minimum of latest training and inference versions and expects the versions to be consistent for training/inference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was created when TF2.9.0 was released.

},
"versions": {
"1.10.0": {
Expand Down Expand Up @@ -1435,6 +1436,36 @@
"us-west-2": "763104351884"
},
"repository": "tensorflow-inference"
},
"2.9.0": {
"registries": {
"af-south-1": "626614931356",
"ap-east-1": "871362719292",
"ap-northeast-1": "763104351884",
"ap-northeast-2": "763104351884",
"ap-northeast-3": "364406365360",
"ap-south-1": "763104351884",
"ap-southeast-1": "763104351884",
"ap-southeast-2": "763104351884",
"ca-central-1": "763104351884",
"cn-north-1": "727897471807",
"cn-northwest-1": "727897471807",
"eu-central-1": "763104351884",
"eu-north-1": "763104351884",
"eu-south-1": "692866216735",
"eu-west-1": "763104351884",
"eu-west-2": "763104351884",
"eu-west-3": "763104351884",
"me-south-1": "217643126080",
"sa-east-1": "763104351884",
"us-east-1": "763104351884",
"us-east-2": "763104351884",
"us-gov-west-1": "442386744353",
"us-iso-east-1": "886529160074",
"us-west-1": "763104351884",
"us-west-2": "763104351884"
},
"repository": "tensorflow-inference"
}
}
},
Expand Down