Skip to content

Add missing arg to Tuner docstring #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Conversation

laurenyu
Copy link
Contributor

Description of changes:
One of the docstrings was missing an arg that got added later, though its usage is already documented in the README

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurenyu laurenyu requested a review from ChoiByungWook July 27, 2018 18:47
@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #319 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   92.92%   92.86%   -0.06%     
==========================================
  Files          50       50              
  Lines        3475     3475              
==========================================
- Hits         3229     3227       -2     
- Misses        246      248       +2
Impacted Files Coverage Δ
src/sagemaker/tuner.py 96.8% <ø> (ø) ⬆️
src/sagemaker/local/image.py 88.85% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ead1f...caa0e3a. Read the comment docs.

@laurenyu laurenyu merged commit 789ec37 into aws:master Jul 30, 2018
@laurenyu laurenyu deleted the tuner-docstring-fix branch July 30, 2018 16:04
jnclt pushed a commit to jnclt/sagemaker-python-sdk that referenced this pull request Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants