feat: Added endpoint_name to clarify.ModelConfig and run_bias_and_explainability #3296

dosatos · 2022-08-12T11:22:41Z

Issue #, if available:

Description of changes:
Added endpoint_name to clarify.ModelConfig, so the users could re-use existing model endpoints.

Testing done:
Added Unit Tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-08-12T11:28:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3f2cea6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T11:35:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ecd1e05
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T12:19:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ecd1e05
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T12:22:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ecd1e05
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T12:38:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ecd1e05
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T12:43:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e6f5e1d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T13:09:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0716a24
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T13:18:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b3b1f53
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T13:26:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3288bd6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T13:28:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3288bd6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T14:08:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 095329e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T14:11:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 04f87ae
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T14:13:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 04f87ae
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T14:22:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ec50f69
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T14:51:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ec50f69
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-08-12T14:52:30Z

Codecov Report

Merging #3296 (5c8275b) into master (b27423d) will decrease coverage by 0.78%.
The diff coverage is 93.42%.

@@            Coverage Diff             @@
##           master    #3296      +/-   ##
==========================================
- Coverage   89.83%   89.05%   -0.79%     
==========================================
  Files         645      203     -442     
  Lines       55647    18349   -37298     
==========================================
- Hits        49990    16340   -33650     
+ Misses       5657     2009    -3648

Impacted Files	Coverage Δ
src/sagemaker/clarify.py	`95.65% <93.42%> (ø)`
...ges/sagemaker/model_monitor/data_capture_config.py
...n3.9/site-packages/sagemaker/pytorch/processing.py
...7/site-packages/sagemaker/amazon/linear_learner.py
...n3.9/site-packages/sagemaker/wrangler/ingestion.py
.../site-packages/sagemaker/workflow/callback_step.py
...ib/python3.8/site-packages/sagemaker/image_uris.py
...ite-packages/sagemaker/debugger/profiler_config.py
...thon3.7/site-packages/sagemaker/mxnet/estimator.py
...3.8/site-packages/sagemaker/workflow/conditions.py
... and 839 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-08-12T15:06:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ec50f69
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T15:07:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ec50f69
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-12T15:18:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ec50f69
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

keerthanvasist

I see some linting changes in this PR. They make the PR harder to review. Usually it is better to avoid them if you can help. Did you run the black check? Not blocking. Otherwise, LGTM.

sagemaker-bot · 2022-08-16T10:08:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5c8275b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-16T10:30:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5c8275b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-16T10:43:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5c8275b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-16T10:58:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5c8275b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-16T12:52:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5c8275b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-17T21:24:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5c8275b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-17T21:39:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5c8275b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-17T21:42:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5c8275b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-08-17T23:31:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5c8275b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

* added run_bias_and_explainability method * feat: added endpoint_name to clarify.ModelConfig Co-authored-by: Yeldos Balgabekov <[email protected]>

dosatos changed the title ~~Clarify/endpoint name~~ Added endpoint_name to clarify.ModelConfig Aug 12, 2022

dosatos changed the title ~~Added endpoint_name to clarify.ModelConfig~~ feat: Added endpoint_name to clarify.ModelConfig Aug 12, 2022

dosatos force-pushed the clarify/endpoint_name branch from 3e88447 to 3f2cea6 Compare August 12, 2022 11:24

dosatos force-pushed the clarify/endpoint_name branch 2 times, most recently from db9cacf to ecd1e05 Compare August 12, 2022 11:31

dosatos force-pushed the clarify/endpoint_name branch from ecd1e05 to e6f5e1d Compare August 12, 2022 12:39

dosatos force-pushed the clarify/endpoint_name branch 2 times, most recently from 06918ed to 0716a24 Compare August 12, 2022 13:05

dosatos force-pushed the clarify/endpoint_name branch 2 times, most recently from b1e63d9 to b3b1f53 Compare August 12, 2022 13:14

dosatos force-pushed the clarify/endpoint_name branch from b3b1f53 to 3288bd6 Compare August 12, 2022 13:24

dosatos force-pushed the clarify/endpoint_name branch 3 times, most recently from 095329e to 04f87ae Compare August 12, 2022 14:08

dosatos force-pushed the clarify/endpoint_name branch 2 times, most recently from 57474fa to ec50f69 Compare August 12, 2022 14:19

keerthanvasist approved these changes Aug 12, 2022

View reviewed changes

aws-byeldos added 2 commits August 16, 2022 11:45

added run_bias_and_explainability method

2dc3867

feat: added endpoint_name to clarify.ModelConfig

5c8275b

dosatos force-pushed the clarify/endpoint_name branch from ec50f69 to 5c8275b Compare August 16, 2022 09:59

BasilBeirouti merged commit 0e9c10e into aws:master Aug 18, 2022

dosatos mentioned this pull request Aug 18, 2022

Added bias_and_explainability to SageMakerClarifyProcessor #3282

Closed

9 tasks

dosatos changed the title ~~feat: Added endpoint_name to clarify.ModelConfig~~ feat: Added endpoint_name to clarify.ModelConfig and expose run_bias_and_explainability Aug 18, 2022

dosatos changed the title ~~feat: Added endpoint_name to clarify.ModelConfig and expose run_bias_and_explainability~~ feat: Added endpoint_name to clarify.ModelConfig and run_bias_and_explainability Aug 18, 2022

feat: Added endpoint_name to clarify.ModelConfig and run_bias_and_explainability #3296

feat: Added endpoint_name to clarify.ModelConfig and run_bias_and_explainability #3296

Uh oh!

Conversation

dosatos commented Aug 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Aug 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 12, 2022

AWS CodeBuild CI Report

Uh oh!

keerthanvasist left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Aug 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 16, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 16, 2022

AWS CodeBuild CI Report

dosatos commented Aug 12, 2022 •

edited

Loading

codecov-commenter commented Aug 12, 2022 •

edited

Loading

keerthanvasist left a comment •

edited

Loading