documentation: add context for pytorch #3352

teebkeng-aws · 2022-09-07T16:23:09Z

Issue #, if available:

Description of changes: I'm adding some updates to the PyTorch docs to document a new parameter ('context') that customers can use for multi-GPU use cases. This update was brought up to the doc team by Wei Chu (@weichu), and the content has been approved by them.

Testing done: Ran the following tox tests locally and passed: black-check,flake8,pylint,docstyle,sphinx,doc8

Build preview: http://dev-dsk-teebkeng-2a-0310d08d.us-west-2.amazon.com/sdk_website/html/frameworks/pytorch/using_pytorch.html#load-a-model

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backword compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

waytrue17

LGTM

sagemaker-bot · 2022-09-23T22:34:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ca08ab3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-09-23T22:35:01Z

Codecov Report

Merging #3352 (4018794) into master (b4ea839) will decrease coverage by 0.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3352      +/-   ##
==========================================
- Coverage   90.01%   89.16%   -0.86%     
==========================================
  Files         868      204     -664     
  Lines       76892    18989   -57903     
==========================================
- Hits        69213    16931   -52282     
+ Misses       7679     2058    -5621

Impacted Files	Coverage Δ
...10/site-packages/sagemaker/serverless/predictor.py
...hon3.7/site-packages/sagemaker/chainer/__init__.py
.../cli/compatibility/v2/modifiers/training_params.py
...python3.7/site-packages/sagemaker/model_metrics.py
...lib/python3.9/site-packages/sagemaker/parameter.py
...python3.9/site-packages/sagemaker/sparkml/model.py
...n3.7/site-packages/sagemaker/pytorch/processing.py
....7/site-packages/sagemaker/huggingface/__init__.py
...7/site-packages/sagemaker/amazon/linear_learner.py
...hon3.9/site-packages/sagemaker/sklearn/__init__.py
... and 1062 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-09-23T22:53:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ca08ab3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-23T23:19:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ca08ab3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-23T23:19:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ca08ab3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-23T23:22:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ca08ab3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T19:11:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T19:11:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T19:11:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T19:11:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-26T19:39:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aaronmarkham

LGTM, but I would suggest running this update on your fork on your own RTD instance and providing the link in the PR description... just so we're really sure that the website looks right.

teebkeng-aws · 2022-09-27T18:52:29Z

Staged preview: http://dev-dsk-teebkeng-2a-0310d08d.us-west-2.amazon.com/sdk_website/html/frameworks/pytorch/using_pytorch.html#load-a-model

sagemaker-bot · 2022-09-27T18:58:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4018794
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-27T19:23:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-27T19:37:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-27T19:44:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-09-27T20:01:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run slow-tests

sagemaker-bot · 2022-09-29T19:22:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4018794
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Basil Beirouti <[email protected]>

documentation: add context for pytorch

1c1b7ea

waytrue17 approved these changes Sep 12, 2022

View reviewed changes

Merge branch 'master' into teebkeng-pytorch-context-update

ca08ab3

Merge branch 'master' into teebkeng-pytorch-context-update

4018794

aaronmarkham approved these changes Sep 27, 2022

View reviewed changes

gmohand requested a review from aaronmarkham September 29, 2022 18:25

mufaddal-rohawala approved these changes Sep 29, 2022

View reviewed changes

knikure self-requested a review September 29, 2022 18:27

mufaddal-rohawala reviewed Sep 29, 2022

View reviewed changes

mufaddal-rohawala merged commit f38b620 into aws:master Sep 29, 2022

vikas0203 assigned vikas0203 and unassigned vikas0203 Sep 30, 2022

vikas0203 self-requested a review September 30, 2022 15:05

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

documentation: add context for pytorch (aws#3352)

71aad2c

Co-authored-by: Basil Beirouti <[email protected]>

documentation: add context for pytorch #3352

documentation: add context for pytorch #3352

Uh oh!

Conversation

teebkeng-aws commented Sep 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

waytrue17 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Sep 23, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Sep 23, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 23, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 26, 2022

AWS CodeBuild CI Report

Uh oh!

aaronmarkham left a comment

Choose a reason for hiding this comment

Uh oh!

teebkeng-aws commented Sep 27, 2022

Uh oh!

sagemaker-bot commented Sep 27, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 27, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 27, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 27, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Sep 27, 2022

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Sep 29, 2022

AWS CodeBuild CI Report

Uh oh!

Uh oh!

teebkeng-aws commented Sep 7, 2022 •

edited

Loading

codecov-commenter commented Sep 23, 2022 •

edited

Loading