Wrap training timeout for integ tests #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 92.93% 92.93%
=======================================
Files 51 51
Lines 3552 3552
=======================================
Hits 3301 3301
Misses 251 251Continue to review full report at Codecov.
|
tests/integ/timeout.py
Outdated
| @@ -59,6 +59,18 @@ def handler(signum, frame): | |||
| signal.alarm(0) | |||
|
|
|||
|
|
|||
| @contextmanager | |||
| def timeout_training(seconds=0, minutes=20, hours=0): | |||
There was a problem hiding this comment.
If the purpose of these two wrappers is to set a default timeout period I would just do something like this:
TRAINING_JOB_DEFAULT_TIMEOUT_MINUTES = 20
with timeout(minutes=TRAINING_JOB_DEFAULT_TIMEOUT_MINUTES)
icywang86rui
approved these changes
Aug 10, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Some training takes about 16-18 minutes and the tests failed several times a week. So I want to increase the timeout to 20 minutes. But for special tests like async or local mode, I did not change the timeout since it worked fine so far.
And to make it easier for future change, I create timeout wrappers for training and tuning.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.