feature: Graviton support for XGB and SKLearn frameworks #3433

mabunday · 2022-10-21T18:11:29Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2022-10-21T18:15:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c55c3f4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T18:25:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d01893e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T18:30:54Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d01893e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T18:59:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d01893e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T19:05:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d01893e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-21T19:26:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d01893e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T06:36:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 88dfbf0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T06:37:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 88dfbf0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2022-10-22T06:37:29Z

Codecov Report

Merging #3433 (3b17943) into master (ecb4ac2) will decrease coverage by 0.83%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3433      +/-   ##
==========================================
- Coverage   89.66%   88.83%   -0.84%     
==========================================
  Files         872      205     -667     
  Lines       77952    19268   -58684     
==========================================
- Hits        69897    17116   -52781     
+ Misses       8055     2152    -5903

Impacted Files	Coverage Δ
src/sagemaker/fw_utils.py	`91.36% <100.00%> (ø)`
src/sagemaker/image_uris.py	`98.67% <100.00%> (ø)`
...ite-packages/sagemaker/debugger/profiler_config.py
...b/python3.7/site-packages/sagemaker/local/utils.py
...ython3.7/site-packages/sagemaker/local/__init__.py
...b/python3.8/site-packages/sagemaker/local/utils.py
...on3.9/site-packages/sagemaker/amazon/object2vec.py
...b/python3.7/site-packages/sagemaker/mxnet/model.py
...3.8/site-packages/sagemaker/workflow/model_step.py
...on3.7/site-packages/sagemaker/workflow/pipeline.py
... and 1069 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2022-10-22T06:47:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 88dfbf0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T06:55:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 88dfbf0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T07:05:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 88dfbf0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T20:32:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7a6b2d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T20:42:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ca93776
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T20:46:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: aff487f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T20:55:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 86f56c3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T21:24:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 86f56c3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T22:04:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6e16a2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-22T22:19:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6e16a2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T19:56:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 682f4fa
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T20:00:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 682f4fa
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T20:06:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c5933a0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T20:08:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c5933a0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T21:08:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d74894f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T21:18:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d74894f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T21:22:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d74894f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T21:22:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d74894f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T21:29:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d74894f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-25T21:40:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d74894f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run slow-tests

sagemaker-bot · 2022-10-25T23:23:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d74894f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-26T17:10:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 3b17943
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-26T17:21:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 3b17943
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-26T17:23:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 3b17943
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-26T17:26:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 3b17943
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2022-10-26T17:42:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 3b17943
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Co-authored-by: Mark Bunday <[email protected]>

mabunday force-pushed the 1p-arm64 branch from c55c3f4 to d01893e Compare October 21, 2022 18:21

mabunday force-pushed the 1p-arm64 branch from d01893e to 88dfbf0 Compare October 22, 2022 06:02

mabunday force-pushed the 1p-arm64 branch 2 times, most recently from ced2e8f to 7a6b2d0 Compare October 22, 2022 20:21

mabunday force-pushed the 1p-arm64 branch 3 times, most recently from 61905cc to ca93776 Compare October 22, 2022 20:38

mabunday force-pushed the 1p-arm64 branch from ca93776 to aff487f Compare October 22, 2022 20:42

mabunday force-pushed the 1p-arm64 branch from aff487f to 86f56c3 Compare October 22, 2022 20:49

mabunday force-pushed the 1p-arm64 branch 2 times, most recently from df690e8 to 6e16a2f Compare October 22, 2022 21:29

mabunday force-pushed the 1p-arm64 branch 2 times, most recently from aa60485 to 682f4fa Compare October 25, 2022 19:52

mabunday force-pushed the 1p-arm64 branch from 682f4fa to c5933a0 Compare October 25, 2022 20:02

feature: Graviton support for XGB and SKLearn frameworks

72a60af

mabunday force-pushed the 1p-arm64 branch from c5933a0 to 72a60af Compare October 25, 2022 20:09

Merge branch 'master' into 1p-arm64

d74894f

knikure reviewed Oct 25, 2022

View reviewed changes

knikure approved these changes Oct 25, 2022

View reviewed changes

Merge branch 'master' into 1p-arm64

3b17943

navinsoni approved these changes Oct 26, 2022

View reviewed changes

navinsoni merged commit b71a050 into aws:master Oct 26, 2022

mizanfiu pushed a commit to mizanfiu/sagemaker-python-sdk that referenced this pull request Dec 13, 2022

feature: Graviton support for XGB and SKLearn frameworks (aws#3433)

f14c43b

Co-authored-by: Mark Bunday <[email protected]>

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

feature: Graviton support for XGB and SKLearn frameworks (aws#3433)

928a76c

Co-authored-by: Mark Bunday <[email protected]>

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

feature: Graviton support for XGB and SKLearn frameworks (aws#3433)

4b9fa37

Co-authored-by: Mark Bunday <[email protected]>

feature: Graviton support for XGB and SKLearn frameworks #3433

feature: Graviton support for XGB and SKLearn frameworks #3433

Uh oh!

Conversation

mabunday commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 21, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Oct 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 22, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2022

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 25, 2022

AWS CodeBuild CI Report

Uh oh!

mabunday commented Oct 21, 2022 •

edited

Loading

codecov-commenter commented Oct 22, 2022 •

edited

Loading