Add batch_get_record and search API for FeatureStore #3580

can-sun · 2023-01-09T19:54:39Z

Issue #, if available:

Description of changes:

Please see https://github.com/aws/sagemaker-python-sdk-staging/pull/787 for all changes

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

trajanikant

/bot run all

sagemaker-bot · 2023-01-10T23:45:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5067bdd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T00:17:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5067bdd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T00:23:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5067bdd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T00:37:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5067bdd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T00:37:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5067bdd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests, unit-tests

sagemaker-bot · 2023-01-11T19:13:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5067bdd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T19:17:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5067bdd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run all

sagemaker-bot · 2023-01-23T19:38:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1f5bad0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-23T20:12:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1f5bad0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-01-23T20:13:48Z

Codecov Report

Merging #3580 (1f5bad0) into master (5cb00a4) will decrease coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3580      +/-   ##
==========================================
- Coverage   89.59%   88.83%   -0.76%     
==========================================
  Files         968      227     -741     
  Lines       89584    22222   -67362     
==========================================
- Hits        80263    19742   -60521     
+ Misses       9321     2480    -6841

Impacted Files	Coverage Δ
src/sagemaker/feature_store/feature_store.py	`96.66% <100.00%> (ø)`
src/sagemaker/feature_store/inputs.py	`99.06% <100.00%> (ø)`
src/sagemaker/session.py	`74.36% <100.00%> (ø)`
...9/lib/python3.9/site-packages/sagemaker/clarify.py
.../lib/python3.9/site-packages/sagemaker/pipeline.py
...python3.8/site-packages/sagemaker/content_types.py
...ib/python3.8/site-packages/sagemaker/model_uris.py
...python3.8/site-packages/sagemaker/deserializers.py
....7/site-packages/sagemaker/serverless/predictor.py
...li/compatibility/v2/modifiers/deprecated_params.py
... and 1188 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-01-23T20:14:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1f5bad0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-23T20:25:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1f5bad0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-23T20:35:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1f5bad0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests, notebook-tests

sagemaker-bot · 2023-01-23T22:16:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1f5bad0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-23T22:29:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1f5bad0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run notebook-tests, slow-tests

sagemaker-bot · 2023-01-24T01:20:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1f5bad0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-24T01:27:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1f5bad0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run notebook-tests

sagemaker-bot · 2023-01-24T02:59:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1f5bad0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run notebook-tests

sagemaker-bot · 2023-01-24T18:58:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1f5bad0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run all

sagemaker-bot · 2023-01-26T18:54:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 829bcd3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-26T18:56:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 829bcd3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-26T18:59:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 829bcd3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-26T19:19:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 829bcd3
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-26T19:23:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 829bcd3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

trajanikant

/bot run slow-tests

sagemaker-bot · 2023-01-26T20:13:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 829bcd3
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This reverts commit 27ebde6.

Add batch_get_record and search API for FeatureStore

5067bdd

can-sun requested a review from a team as a code owner January 9, 2023 19:54

can-sun requested review from knikure and removed request for a team January 9, 2023 19:54

knikure self-assigned this Jan 9, 2023

trajanikant reviewed Jan 10, 2023

View reviewed changes

trajanikant reviewed Jan 11, 2023

View reviewed changes

Merge branch 'master' into master

1f5bad0

trajanikant reviewed Jan 23, 2023

View reviewed changes

trajanikant reviewed Jan 24, 2023

View reviewed changes

Merge branch 'master' into master

829bcd3

trajanikant reviewed Jan 26, 2023

View reviewed changes

trajanikant merged commit 27ebde6 into aws:master Jan 27, 2023

trajanikant assigned trajanikant and unassigned knikure Jan 27, 2023

trajanikant added a commit that referenced this pull request Jan 27, 2023

Revert "Add batch_get_record and search API for FeatureStore (#3580)"

e95aaf1

This reverts commit 27ebde6.

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

Add batch_get_record and search API for FeatureStore (aws#3580)

9af57ca

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

Add batch_get_record and search API for FeatureStore (aws#3580)

86afb2c

Add batch_get_record and search API for FeatureStore #3580

Add batch_get_record and search API for FeatureStore #3580

Uh oh!

Conversation

can-sun commented Jan 9, 2023

Merge Checklist

General

Tests

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 10, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 23, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jan 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 23, 2023

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 23, 2023

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 24, 2023

AWS CodeBuild CI Report

Uh oh!

trajanikant left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jan 24, 2023

codecov-commenter commented Jan 23, 2023 •

edited

Loading