change: Enable load_run without name args in Transform env #3585

qidewenwhen · 2023-01-11T02:17:36Z

Description of changes:

As transform job team has helped to add a env var to supply the job source arn, it's a good time to enable load_run without name args in Transform env
Clean up some TODO items in the unit/integ tests
Clean up two unused clases

Testing done: unit tests and integ tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-01-11T02:24:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f2e3f0b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T02:58:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f2e3f0b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-01-11T03:00:05Z

Codecov Report

Merging #3585 (36b7aea) into master (1fa2377) will decrease coverage by 0.39%.
The diff coverage is 87.53%.

@@            Coverage Diff             @@
##           master    #3585      +/-   ##
==========================================
- Coverage   89.17%   88.78%   -0.39%     
==========================================
  Files         204      227      +23     
  Lines       18979    22108    +3129     
==========================================
+ Hits        16924    19628    +2704     
- Misses       2055     2480     +425

Impacted Files	Coverage Δ
src/sagemaker/dataset_definition/inputs.py	`100.00% <ø> (ø)`
src/sagemaker/huggingface/model.py	`89.87% <ø> (ø)`
src/sagemaker/lineage/_utils.py	`100.00% <ø> (+12.50%)`	⬆️
src/sagemaker/pipeline.py	`85.33% <ø> (ø)`
src/sagemaker/rl/estimator.py	`93.05% <ø> (ø)`
src/sagemaker/session.py	`74.09% <ø> (+2.42%)`	⬆️
src/sagemaker/session_settings.py	`100.00% <ø> (ø)`
src/sagemaker/sklearn/estimator.py	`93.93% <ø> (-6.07%)`	⬇️
src/sagemaker/sklearn/model.py	`92.98% <ø> (-1.76%)`	⬇️
src/sagemaker/spark/processing.py	`98.70% <ø> (+0.08%)`	⬆️
... and 98 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-01-11T03:00:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f2e3f0b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T03:01:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f2e3f0b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T03:16:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f2e3f0b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T19:01:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f2e3f0b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-11T20:46:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f2e3f0b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-12T19:03:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f2e3f0b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-14T04:42:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 685d543
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-14T05:17:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 685d543
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-14T05:20:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 685d543
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-14T05:39:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 685d543
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-14T05:51:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 685d543
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T19:24:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 254c5a2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T20:00:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 254c5a2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T20:01:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 254c5a2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T20:14:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 254c5a2
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-18T20:21:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 254c5a2
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T18:34:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 19abc2b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T19:08:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 19abc2b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T19:10:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 19abc2b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T21:50:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 36b7aea
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T22:00:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 36b7aea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-19T23:47:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 36b7aea
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell

/bot run slow-tests

sagemaker-bot · 2023-01-27T18:36:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 36b7aea
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

claytonparnell · 2023-01-27T18:44:11Z

@qidewenwhen - sorry this has been open so long; could you please resolve merge conflict then we can get it merged?

sagemaker-bot · 2023-01-27T19:38:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 36b7aea
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-27T21:35:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 36b7aea
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

qidewenwhen · 2023-01-27T22:52:12Z

@qidewenwhen - sorry this has been open so long; could you please resolve merge conflict then we can get it merged?

Thanks @claytonparnell! Resolving the conflicts right now.
This PR is still pending internal team review. Will bump it up again in internal team channel next Monday.
Once we get internal approvals, we can move forward to merge.

sagemaker-bot · 2023-01-28T00:04:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 886dc4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-28T00:10:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 886dc4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-28T00:24:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 886dc4d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-28T00:26:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 886dc4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-28T00:51:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 886dc4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/experiments/_environment.py

danabens · 2023-01-30T18:45:27Z

we need to talk to the client frameworks team about slow tests, just causing constant failures in PRs - not providing any value

(11 durations < 0.005s hidden.  Use -vv to show these durations.)
=========================== short test summary info ============================
FAILED tests/integ/test_inference_pipeline.py::test_inference_pipeline_model_deploy_and_update_endpoint
============= 1 failed, 15 passed, 1 warning in 3533.54s (0:58:53) =============
ERROR: InvocationError for command /codebuild/output/src083470416/src/github.com/aws/sagemaker-python-sdk/.tox/py310/bin/pytest --cov=sagemaker --cov-append tests/integ -m slow_test -n 16 --durations 0 (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   py310: commands failed

sagemaker-bot · 2023-01-30T20:03:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 886dc4d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-30T21:36:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 886dc4d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-31T00:41:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 886dc4d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-01-31T19:35:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 886dc4d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-01T00:23:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 886dc4d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

qidewenwhen requested a review from a team as a code owner January 11, 2023 02:17

qidewenwhen requested review from claytonparnell and removed request for a team January 11, 2023 02:17

knikure assigned claytonparnell Jan 11, 2023

qidewenwhen force-pushed the exp branch from f2e3f0b to 685d543 Compare January 14, 2023 04:36

qidewenwhen requested a review from danabens January 18, 2023 18:35

qidewenwhen force-pushed the exp branch from 685d543 to 254c5a2 Compare January 18, 2023 19:18

qidewenwhen force-pushed the exp branch from 254c5a2 to 19abc2b Compare January 19, 2023 18:28

claytonparnell reviewed Jan 27, 2023

View reviewed changes

change: Enable load_run without name args in Transform env

886dc4d

qidewenwhen force-pushed the exp branch from 36b7aea to 886dc4d Compare January 27, 2023 23:22

danabens reviewed Jan 30, 2023

View reviewed changes

src/sagemaker/experiments/_environment.py Show resolved Hide resolved

danabens approved these changes Jan 30, 2023

View reviewed changes

leoroy approved these changes Jan 30, 2023

View reviewed changes

claytonparnell approved these changes Feb 1, 2023

View reviewed changes

mufaddal-rohawala merged commit 9e2a586 into aws:master Feb 1, 2023

JoseJuan98 pushed a commit to JoseJuan98/sagemaker-python-sdk that referenced this pull request Mar 4, 2023

change: Enable load_run without name args in Transform env (aws#3585)

acafbb2

nmadan pushed a commit to nmadan/sagemaker-python-sdk that referenced this pull request Apr 18, 2023

change: Enable load_run without name args in Transform env (aws#3585)

0c54071

qidewenwhen deleted the exp branch January 25, 2024 18:33

change: Enable load_run without name args in Transform env #3585

change: Enable load_run without name args in Transform env #3585

Uh oh!

Conversation

qidewenwhen commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jan 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 14, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 14, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 14, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 14, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 14, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jan 19, 2023

AWS CodeBuild CI Report

Uh oh!

qidewenwhen commented Jan 11, 2023 •

edited

Loading

codecov-commenter commented Jan 11, 2023 •

edited

Loading

claytonparnell left a comment •

edited

Loading