fix: Extracted profile_name directly from sagemaker.Session if None #3660

kusumbhatt · 2023-02-15T17:02:42Z

Issue #, if available:

Description of changes:

FeatureGroup class is instantiated with a boto3 Session that would be using the default or custom credential profile. When ingesting records into feature group using multi-threading / multi-processing mode, a new session is created in every thread. If customers don't pass the profile_name of the boto3 session to ingest(..) method, new sessions will fallback to default profile, which might fail.

So, the current fix extracts profile_name directly from the sagemaker.Session object if no profile_name has been passed in the ingest(..) method which will be a better customer experience especially if the customer forgets to specify the profile_name. This change will ensure the profile_name is initialized to that of boto3 session during record ingestion.

Testing done:

The change is tested by installing the binary locally and running a local script having boto3 debug logs enabled which confirmed that the required profile_name is being used to initialize the session.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

claytonparnell

/bot run slow-tests

sagemaker-bot · 2023-02-16T16:51:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5938849
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-16T17:27:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5938849
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-16T17:35:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5938849
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-16T17:50:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5938849
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-16T19:29:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5938849
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-02-16T19:29:51Z

Codecov Report

Merging #3660 (bcd9b7a) into master (2e44a2c) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3660      +/-   ##
==========================================
- Coverage   89.74%   88.96%   -0.79%     
==========================================
  Files         968      227     -741     
  Lines       91124    22539   -68585     
==========================================
- Hits        81780    20051   -61729     
+ Misses       9344     2488    -6856

Impacted Files	Coverage Δ
src/sagemaker/feature_store/feature_group.py	`74.78% <100.00%> (ø)`
...ite-packages/sagemaker/debugger/profiler_config.py
...n3.8/site-packages/sagemaker/workflow/functions.py
...n3.9/site-packages/sagemaker/xgboost/processing.py
...ython3.10/site-packages/sagemaker/lineage/query.py
...ython3.8/site-packages/sagemaker/lineage/action.py
....7/site-packages/sagemaker/jumpstart/exceptions.py
...n3.7/site-packages/sagemaker/lineage/_api_types.py
...-packages/sagemaker/dataset_definition/__init__.py
...thon3.8/site-packages/sagemaker/jumpstart/types.py
... and 1186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

claytonparnell

/bot run slow-tests

sagemaker-bot · 2023-02-22T16:26:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a75ee66
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-22T16:55:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a75ee66
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-22T17:06:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a75ee66
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-22T17:11:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a75ee66
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-22T17:17:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a75ee66
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-22T19:38:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a75ee66
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-23T16:32:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a75ee66
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-02-23T18:46:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a75ee66
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T16:58:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bdaa1e0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T17:29:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: bdaa1e0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T17:39:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bdaa1e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T17:47:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bdaa1e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T17:49:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bdaa1e0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

… is not default

sagemaker-bot · 2023-03-01T18:26:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bcd9b7a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T18:56:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: bcd9b7a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T19:07:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bcd9b7a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T19:10:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: bcd9b7a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-01T19:15:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: bcd9b7a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-03T21:50:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bcd9b7a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-03T23:02:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bcd9b7a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-03-06T16:21:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: bcd9b7a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ws#3660) * fix: Extracted profile_name directly from sagemaker.Session if None * Extracted profile_name only if profile_name used in sagemaker_session is not default --------- Co-authored-by: Kusumlata Bhatt <[email protected]>

kusumbhatt requested a review from a team as a code owner February 15, 2023 17:02

kusumbhatt requested review from claytonparnell and removed request for a team February 15, 2023 17:02

claytonparnell reviewed Feb 16, 2023

View reviewed changes

claytonparnell self-assigned this Feb 16, 2023

fix: Extracted profile_name directly from sagemaker.Session if None

a75ee66

claytonparnell force-pushed the development branch from 5938849 to a75ee66 Compare February 22, 2023 02:46

claytonparnell reviewed Feb 22, 2023

View reviewed changes

Merge branch 'aws:master' into development

bdaa1e0

Extracted profile_name only if profile_name used in sagemaker_session…

bcd9b7a

… is not default

kusumbhatt requested a review from claytonparnell March 2, 2023 19:57

claytonparnell approved these changes Mar 9, 2023

View reviewed changes

claytonparnell merged commit 5987cc8 into aws:master Mar 9, 2023

fix: Extracted profile_name directly from sagemaker.Session if None #3660

fix: Extracted profile_name directly from sagemaker.Session if None #3660

Uh oh!

Conversation

kusumbhatt commented Feb 15, 2023

Merge Checklist

General

Tests

Uh oh!

claytonparnell left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 16, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Feb 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

claytonparnell left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Feb 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Feb 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Mar 1, 2023

AWS CodeBuild CI Report

claytonparnell left a comment •

edited

Loading

codecov-commenter commented Feb 16, 2023 •

edited

Loading

claytonparnell left a comment •

edited

Loading