Skip to content

feature: SDK changes for TRCOMP support #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 16, 2023
Merged

feature: SDK changes for TRCOMP support #3714

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1c68699
SDK changes for TRCOMP support
BruceChang9688 Mar 13, 2023
668064b
fix syntax error
BruceChang9688 Mar 13, 2023
2083bac
fix format issue
BruceChang9688 Mar 13, 2023
c1955db
fix pylint issue
BruceChang9688 Mar 13, 2023
50f4e14
Merge branch 'master' into trcomp-sdk
BruceChang9688 Mar 13, 2023
071303c
edit frameversion comment and specifier set function
BruceChang9688 Mar 14, 2023
3c0e511
Merge branch 'trcomp-sdk' of https://github.com/BruceChang9688/sagema…
BruceChang9688 Mar 14, 2023
df4bbdc
Merge branch 'master' into trcomp-sdk
BruceChang9688 Mar 14, 2023
32b9c79
fix format issue
BruceChang9688 Mar 14, 2023
5b2daa4
edit unit test for trcomp support version coverage
BruceChang9688 Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/sagemaker/huggingface/training_compiler/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,17 @@ def validate(cls, estimator):

super(TrainingCompilerConfig, cls).validate(estimator)

if estimator.pytorch_version:
if (Version(estimator.pytorch_version) in SpecifierSet("< 1.9")) or (
Version(estimator.pytorch_version) in SpecifierSet("> 1.11")
):
error_helper_string = (
"Training Compiler is only valid between HuggingFace PyTorch 1.9-1.11 "
"for SageMaker Training Compiler."
" Received pytorch_version={} which is unsupported."
)
raise ValueError(error_helper_string.format(estimator.pytorch_version))

if estimator.image_uri:
error_helper_string = (
"Overriding the image URI is currently not supported "
Expand Down
12 changes: 12 additions & 0 deletions src/sagemaker/tensorflow/training_compiler/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class TrainingCompilerConfig(BaseConfig):

SUPPORTED_INSTANCE_CLASS_PREFIXES = ["p3", "p3dn", "g4dn", "p4d", "g5"]
MIN_SUPPORTED_VERSION = "2.9"
MAX_SUPPORTED_VERSION = "2.11"

def __init__(self, enabled=True, debug=False):
"""This class initializes a ``TrainingCompilerConfig`` instance.
Expand Down Expand Up @@ -102,6 +103,17 @@ def validate(cls, estimator):
cls.MIN_SUPPORTED_VERSION, estimator.framework_version
)
raise ValueError(error_helper_string)
if Version(estimator.framework_version) in SpecifierSet(
f"> {cls.MAX_SUPPORTED_VERSION}"
):
error_helper_string = (
"SageMaker Training Compiler only supports TensorFlow version "
"<= {} but received {}"
)
error_helper_string = error_helper_string.format(
cls.MAX_SUPPORTED_VERSION, estimator.framework_version
)
raise ValueError(error_helper_string)

if estimator.distribution and "multi_worker_mirrored_strategy" in estimator.distribution:
mwms_enabled = estimator.distribution.get("multi_worker_mirrored_strategy").get(
Expand Down