-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: combined model + script artifact #3715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
claytonparnell
merged 12 commits into
aws:master
from
evakravi:feat/model-uri-with-script
Mar 24, 2023
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8bb9cba
feat: combined model + script artifact
evakravi 02f3a82
chore: use ValueError
evakravi 38f8634
chore: improve error msg for no combined artifact
evakravi 29243ae
fix: jumpstart unit tests
evakravi 939c77c
chore: always include inference script if available
evakravi b87f794
Merge branch 'master' into feat/model-uri-with-script
evakravi 29724c2
Merge branch 'master' into feat/model-uri-with-script
evakravi 39bb144
Merge branch 'master' into feat/model-uri-with-script
evakravi 1949f9c
Merge branch 'master' into feat/model-uri-with-script
evakravi 65a5543
Merge branch 'master' into feat/model-uri-with-script
evakravi 1bd89e5
Merge branch 'master' into feat/model-uri-with-script
evakravi c1f9587
Merge branch 'master' into feat/model-uri-with-script
evakravi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
tests/unit/sagemaker/model_uris/jumpstart/test_combined_artifact.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You | ||
# may not use this file except in compliance with the License. A copy of | ||
# the License is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is | ||
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF | ||
# ANY KIND, either express or implied. See the License for the specific | ||
# language governing permissions and limitations under the License. | ||
from __future__ import absolute_import | ||
|
||
from mock.mock import patch | ||
|
||
from sagemaker import model_uris | ||
|
||
from tests.unit.sagemaker.jumpstart.utils import get_special_model_spec | ||
|
||
|
||
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs") | ||
def test_jumpstart_combined_artifacts(patched_get_model_specs): | ||
|
||
patched_get_model_specs.side_effect = get_special_model_spec | ||
|
||
model_id_combined_model_artifact = "huggingface-text2text-flan-t5-xxl-fp16" | ||
|
||
uri = model_uris.retrieve( | ||
region="us-west-2", | ||
model_scope="inference", | ||
model_id=model_id_combined_model_artifact, | ||
model_version="*", | ||
) | ||
assert ( | ||
uri == "s3://jumpstart-cache-prod-us-west-2/huggingface-infer/" | ||
"prepack/v1.0.0/infer-prepack-huggingface-text2text-flan-t5-xxl-fp16.tar.gz" | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be opposed to adding the
training_prepacked_script_key
in this PR along with similar logic for retrieval?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that in another PR