feature: Support TF2.12 SageMaker DLC #3776

tejaschumbalkar · 2023-04-11T21:59:10Z

Issue #, if available:

Description of changes:

support TF2.12 SageMaker DLC
Add p2 deprecation notice

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-04-11T22:03:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9cd3631
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-11T22:51:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0cca8a0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-11T23:29:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0cca8a0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-11T23:35:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0cca8a0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-11T23:41:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0cca8a0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-11T23:48:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0cca8a0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-04-11T23:50:41Z

Codecov Report

Merging #3776 (5906311) into master (b334d4e) will decrease coverage by 0.74%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #3776      +/-   ##
==========================================
- Coverage   89.87%   89.13%   -0.74%     
==========================================
  Files        1056      246     -810     
  Lines      100912    24974   -75938     
==========================================
- Hits        90693    22261   -68432     
+ Misses      10219     2713    -7506

Impacted Files	Coverage Δ
src/sagemaker/workflow/functions.py	`94.73% <ø> (ø)`
src/sagemaker/image_uris.py	`98.48% <66.66%> (ø)`

... and 1300 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sagemaker-bot · 2023-04-12T01:04:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7eb66c7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T01:18:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7eb66c7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T01:22:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7eb66c7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T01:24:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7eb66c7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T01:30:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7eb66c7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T17:26:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0b37b93
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T18:07:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0b37b93
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T18:11:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0b37b93
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T18:21:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0b37b93
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-12T18:28:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0b37b93
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T03:37:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0e0a02a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T04:07:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0e0a02a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T04:20:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0e0a02a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T04:21:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0e0a02a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T04:25:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0e0a02a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T16:52:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 393e62e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T16:52:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 393e62e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T16:52:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 393e62e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T17:44:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 393e62e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-13T18:00:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 393e62e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-14T05:19:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4966c1d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tejaschumbalkar · 2023-04-14T17:19:38Z

@Lokiiiiii Ready for review

ShiboXing · 2023-04-17T17:59:23Z

src/sagemaker/image_uri_config/tensorflow.json

+                    "ap-southeast-3": "907027046896",
+                    "ap-southeast-4": "457447274322",
+                    "ca-central-1": "763104351884",
+                    "eu-central-1": "763104351884",


cn regions are to be added after the SM platform update right?

ShiboXing · 2023-04-17T18:00:16Z

P2 deprecation changes look good

vikas0203

/bot run slow-tests,pr

sagemaker-bot · 2023-04-18T21:23:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4966c1d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-18T23:46:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4966c1d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run all

sagemaker-bot · 2023-04-24T21:39:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5906311
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-24T21:52:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5906311
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-24T21:58:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5906311
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-24T22:09:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5906311
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-04-24T23:54:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5906311
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

tejaschumbalkar requested a review from a team as a code owner April 11, 2023 21:59

tejaschumbalkar requested review from vikas0203 and removed request for a team April 11, 2023 21:59

mufaddal-rohawala assigned vikas0203 Apr 14, 2023

Lokiiiiii approved these changes Apr 14, 2023

View reviewed changes

ShiboXing reviewed Apr 17, 2023

View reviewed changes

ShiboXing approved these changes Apr 17, 2023

View reviewed changes

vikas0203 reviewed Apr 18, 2023

View reviewed changes

tejaschumbalkar added 8 commits April 24, 2023 13:59

support TF2.12

248752e

fix unit test

5723889

update python version

6acf4d3

fix python version

b66868a

fix test failures

a68e383

fix framework version

a7e19f4

fix versioning for trcomp

bfa3839

ignore runs in specific regions

5906311

knikure force-pushed the support-tf212 branch from 4966c1d to 5906311 Compare April 24, 2023 20:59

knikure assigned knikure and unassigned vikas0203 Apr 24, 2023

knikure reviewed Apr 24, 2023

View reviewed changes

knikure approved these changes Apr 24, 2023

View reviewed changes

knikure changed the title ~~support TF2.12 SageMaker DLC~~ feature: Support TF2.12 SageMaker DLC Apr 24, 2023

knikure merged commit 9317e08 into aws:master Apr 24, 2023

feature: Support TF2.12 SageMaker DLC #3776

feature: Support TF2.12 SageMaker DLC #3776

Conversation

tejaschumbalkar commented Apr 11, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Apr 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 11, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 11, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Apr 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 13, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 13, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 13, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 13, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 13, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 13, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Apr 13, 2023

AWS CodeBuild CI Report

codecov-commenter commented Apr 11, 2023 •

edited

Loading