Skip to content

Update the list of extension packages pylint is allowed to load #3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2023

Conversation

wimlewis-amazon
Copy link
Contributor

Description of changes:

Adds some of the standard CPython extension packages to pylint's allow list.

This greatly reduces the number of spurious error messages pylint generates, making it a bit easier to see any actual warnings/errors in the output.

Also changed the configuration key to extension-pkg-allow-list. This is supported since pylint-2.7.3 (March 2021).

Testing done:

This only affects the test suite, which still runs.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wimlewis-amazon wimlewis-amazon requested a review from a team as a code owner May 19, 2023 20:34
@wimlewis-amazon wimlewis-amazon requested review from mufaddal-rohawala and removed request for a team May 19, 2023 20:34
Copy link
Contributor

@knikure knikure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 9876559
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 9876559
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 9876559
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 9876559
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 9876559
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

Merging #3873 (9876559) into master (0f37695) will decrease coverage by 0.62%.
The diff coverage is 92.50%.

@@            Coverage Diff             @@
##           master    #3873      +/-   ##
==========================================
- Coverage   89.96%   89.34%   -0.62%     
==========================================
  Files        1140      268     -872     
  Lines      105744    26180   -79564     
==========================================
- Hits        95129    23391   -71738     
+ Misses      10615     2789    -7826     
Impacted Files Coverage Δ
src/sagemaker/huggingface/processing.py 100.00% <ø> (ø)
src/sagemaker/model_monitor/data_capture_config.py 68.75% <ø> (ø)
src/sagemaker/model_monitor/model_monitoring.py 69.60% <ø> (ø)
src/sagemaker/model_monitor/monitoring_files.py 42.15% <ø> (ø)
src/sagemaker/pytorch/model.py 96.82% <ø> (ø)
src/sagemaker/remote_function/job.py 88.93% <ø> (ø)
src/sagemaker/tensorflow/estimator.py 93.02% <0.00%> (ø)
src/sagemaker/workflow/clarify_check_step.py 96.91% <ø> (ø)
src/sagemaker/workflow/pipeline.py 95.03% <0.00%> (ø)
src/sagemaker/workflow/pipeline_context.py 96.19% <ø> (ø)
... and 20 more

... and 1378 files with indirect coverage changes

@knikure knikure merged commit a40f64a into aws:master May 22, 2023
@wimlewis-amazon wimlewis-amazon deleted the nitfix2 branch April 22, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants