fix: Update neo multiversion support to include edge devices #3875

mnuyens · 2023-05-22T18:19:07Z

Description of changes:
Fixing a bug that was stopping version information from being passed to Neo service even when Neo supports versions for that edge target.

Testing done:
Added unit tests to validate that devices that should now pass version info do, and that devices that shouldn't still don't

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-05-22T18:23:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 76add39
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-22T19:04:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 76add39
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-22T19:08:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 76add39
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-22T19:20:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 76add39
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-22T19:24:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 76add39
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-22T20:23:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: ee69e46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-22T20:33:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: ee69e46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-22T20:47:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: ee69e46
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-22T20:53:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: ee69e46
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-05-22T22:41:09Z

Codecov Report

Merging #3875 (ee69e46) into master (abd94ab) will decrease coverage by 0.74%.
The diff coverage is 100.00%.

❗ Current head ee69e46 differs from pull request most recent head b97a502. Consider uploading reports for the commit b97a502 to get more accurate results

@@            Coverage Diff             @@
##           master    #3875      +/-   ##
==========================================
- Coverage   90.08%   89.34%   -0.74%     
==========================================
  Files        1148      268     -880     
  Lines      106048    26183   -79865     
==========================================
- Hits        95534    23394   -72140     
+ Misses      10514     2789    -7725

Impacted Files	Coverage Δ
src/sagemaker/model.py	`93.76% <100.00%> (ø)`

... and 1415 files with indirect coverage changes

sagemaker-bot · 2023-05-22T22:41:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: ee69e46
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T03:11:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 92b316f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T03:15:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 92b316f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T03:16:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 92b316f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T03:31:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 92b316f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T03:38:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 92b316f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T17:31:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 269ae4e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T18:07:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 269ae4e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T18:13:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 269ae4e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T18:36:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 269ae4e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-23T18:37:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 269ae4e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-25T18:58:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b97a502
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-25T19:00:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b97a502
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-25T19:17:35Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b97a502
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-25T19:18:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b97a502
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-05-25T19:25:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b97a502
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run slow-tests

sagemaker-bot · 2023-05-25T23:19:24Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b97a502
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mnuyens · 2023-05-30T21:38:28Z

/bot run slow-tests

knikure · 2023-05-31T16:26:32Z

@mnuyens Can you also get a review from your team on this PR?

HappyAmazonian · 2023-06-01T20:48:41Z

src/sagemaker/model.py

@@ -836,11 +847,14 @@ def multi_version_compilation_supported(
                multi_version_frameworks_support_mapping = {
                    "inferentia": ["pytorch", "tensorflow", "mxnet"],
                    "neo_ioc_targets": ["pytorch", "tensorflow"],
+                    "neo_edge_targets": ["pytorch", "tensorflow"],
                }
                if target_instance_type in NEO_IOC_TARGET_DEVICES:
                    return framework in multi_version_frameworks_support_mapping["neo_ioc_targets"]
                if target_instance_type == "ml_inf1":


Will trainium and inferentia2 support multi version too? It probably doesn't matter now. We may want to change it after they get released

lekk32 · 2023-06-01T21:01:55Z

src/sagemaker/model.py

@@ -69,6 +69,17 @@

 NEO_IOC_TARGET_DEVICES = ["ml_c4", "ml_c5", "ml_m4", "ml_m5", "ml_p2", "ml_p3", "ml_g4dn"]

+NEO_MULTIVERSION_UNSUPPORTED = [


Curious which edge targets do we want to support?

https://docs.aws.amazon.com/sagemaker/latest/dg/neo-supported-devices-edge-devices.html

mnuyens requested a review from a team as a code owner May 22, 2023 18:19

mnuyens requested review from font44 and removed request for a team May 22, 2023 18:19

knikure requested review from knikure and removed request for font44 May 22, 2023 18:30

knikure self-assigned this May 22, 2023

mnuyens force-pushed the master branch from 76add39 to ee69e46 Compare May 22, 2023 19:40

mnuyens force-pushed the master branch from ee69e46 to 92b316f Compare May 23, 2023 02:25

mnuyens force-pushed the master branch from 92b316f to 269ae4e Compare May 23, 2023 17:17

knikure changed the title ~~fix: updating neo multiversion support to include edge devices~~ fix: Update neo multiversion support to include edge devices May 23, 2023

fix: updating neo multiversion support to include edge devices

b97a502

mnuyens force-pushed the master branch from 269ae4e to b97a502 Compare May 25, 2023 18:11

knikure approved these changes May 25, 2023

View reviewed changes

knikure reviewed May 25, 2023

View reviewed changes

chnnmz approved these changes Jun 1, 2023

View reviewed changes

HappyAmazonian reviewed Jun 1, 2023

View reviewed changes

HappyAmazonian approved these changes Jun 1, 2023

View reviewed changes

lekk32 reviewed Jun 1, 2023

View reviewed changes

lekk32 approved these changes Jun 1, 2023

View reviewed changes

knikure merged commit 9f2a192 into aws:master Jun 2, 2023

		@@ -69,6 +69,17 @@

		NEO_IOC_TARGET_DEVICES = ["ml_c4", "ml_c5", "ml_m4", "ml_m5", "ml_p2", "ml_p3", "ml_g4dn"]

		NEO_MULTIVERSION_UNSUPPORTED = [

fix: Update neo multiversion support to include edge devices #3875

fix: Update neo multiversion support to include edge devices #3875

Uh oh!

Conversation

mnuyens commented May 22, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented May 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented May 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented May 25, 2023

codecov-commenter commented May 22, 2023 •

edited

Loading

HappyAmazonian Jun 1, 2023 •

edited

Loading