feat: Add support for Deployment Recommendation ID in model.deploy(). No tagging support #3920

gwang111 · 2023-06-09T00:38:56Z

Issue #, if available:
The Inference Experience Team has launched a new feature called Deployment Recommendation that can be retrieved from the DescribeModel API. Provide PythonSDK support for deployment via Deployment Recommendation ID

See: #3695

Description of changes:

within inference_recommender_mixin -> provided support for Deployment Recommendation ID
add requisite unit tests
add requisite integ tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-06-09T00:43:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 7b194d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T01:17:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 7b194d0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T01:30:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7b194d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T01:32:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 7b194d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T04:12:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 7b194d0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T17:08:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6b92057
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T17:21:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6b92057
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T17:24:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6b92057
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T17:25:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6b92057
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T18:12:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6b92057
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T18:16:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6b92057
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T18:26:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6b92057
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T18:26:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6b92057
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-09T18:57:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6b92057
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-06-09T19:00:47Z

Codecov Report

Merging #3920 (6b92057) into master (f1a809c) will decrease coverage by 0.72%.
The diff coverage is 88.37%.

@@            Coverage Diff             @@
##           master    #3920      +/-   ##
==========================================
- Coverage   90.08%   89.37%   -0.72%     
==========================================
  Files        1156      271     -885     
  Lines      106700    26404   -80296     
==========================================
- Hits        96121    23598   -72523     
+ Misses      10579     2806    -7773

Impacted Files	Coverage Δ
src/sagemaker/model.py	`93.78% <ø> (ø)`
...ference_recommender/inference_recommender_mixin.py	`93.19% <88.37%> (ø)`

... and 1425 files with indirect coverage changes

gwang111 requested a review from a team as a code owner June 9, 2023 00:38

gwang111 requested review from claytonparnell and removed request for a team June 9, 2023 00:38

jinpengqi and others added 13 commits June 9, 2023 09:31

Add deployment support for instant recommendations

93a04e6

Refactor get_recommendation

69a6601

Modify to check recommendations job res first.

b6c2905

Update exception msg

1d1f7c0

add tags for inf and dep recommendations

820793d

Code Formatting

eccbd67

remove hardcoded tag

71aaa52

add doc string and fix unit tests

3c83ee6

formatting

70f0641

integ test formatting

b39609d

update model package tests

d19caf4

drop tagging functionality for now

31d9ebe

drop tagging constants

6b92057

gwang111 force-pushed the jinpeng_deployment_rec_no_tagging branch from 7b194d0 to 6b92057 Compare June 9, 2023 16:31

jbarz1 approved these changes Jun 9, 2023

View reviewed changes

knikure approved these changes Jun 9, 2023

View reviewed changes

knikure merged commit 12b19ee into aws:master Jun 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add support for Deployment Recommendation ID in model.deploy(). No tagging support #3920

feat: Add support for Deployment Recommendation ID in model.deploy(). No tagging support #3920

Uh oh!

gwang111 commented Jun 9, 2023 •

edited

Loading

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

sagemaker-bot commented Jun 9, 2023

Uh oh!

codecov-commenter commented Jun 9, 2023

Uh oh!

Uh oh!

feat: Add support for Deployment Recommendation ID in model.deploy(). No tagging support #3920

feat: Add support for Deployment Recommendation ID in model.deploy(). No tagging support #3920

Uh oh!

Conversation

gwang111 commented Jun 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 9, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jun 9, 2023

Codecov Report

Uh oh!

Uh oh!

gwang111 commented Jun 9, 2023 •

edited

Loading