You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 integ-tests are failing due to ParamValidation Error:
Can you take a look once
FAILED tests/integ/test_marketplace.py::test_marketplace_attach - botocore.ex...
FAILED tests/integ/test_marketplace.py::test_marketplace_transform_job - boto...
=================================== FAILURES ===================================
___________________________ test_marketplace_attach ____________________________
[gw220] linux -- Python 3.7.13 /codebuild/output/src470532371/src/github.com/aws/sagemaker-python-sdk/.tox/py37/bin/python
sagemaker_session = <sagemaker.session.Session object at 0x7f9e43fa5a90>
cpu_instance_type = 'ml.m4.xlarge'
@pytest.mark.skipif(
tests.integ.test_region() in tests.integ.NO_MARKET_PLACE_REGIONS,
reason="Marketplace is not available in {}".format(tests.integ.test_region()),
)
def test_marketplace_attach(sagemaker_session, cpu_instance_type):
with timeout(minutes=15):
data_path = os.path.join(DATA_DIR, "marketplace", "training")
region = sagemaker_session.boto_region_name
account = REGION_ACCOUNT_MAP[region]
algorithm_arn = ALGORITHM_ARN.format(
partition=_aws_partition(region), region=region, account=account
)
mktplace = AlgorithmEstimator(
algorithm_arn=algorithm_arn,
role="SageMakerRole",
instance_count=1,
instance_type=cpu_instance_type,
sagemaker_session=sagemaker_session,
base_job_name=unique_name_from_base("test-marketplace"),
)
train_input = mktplace.sagemaker_session.upload_data(
path=data_path, key_prefix="integ-test-data/marketplace/train"
)
mktplace.fit({"training": train_input}, wait=False)
training_job_name = mktplace.latest_training_job.name
print("Waiting to re-attach to the training job: %s" % training_job_name)
time.sleep(20)
endpoint_name = "test-marketplace-estimator{}".format(sagemaker_timestamp())
with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session, minutes=20):
print("Re-attaching now to: %s" % training_job_name)
estimator = AlgorithmEstimator.attach(
training_job_name=training_job_name, sagemaker_session=sagemaker_session
)
predictor = estimator.deploy(
> 1, cpu_instance_type, endpoint_name=endpoint_name, serializer=CSVSerializer()
)
tests/integ/test_marketplace.py:150:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.tox/py37/lib/python3.7/site-packages/sagemaker/estimator.py:1632: in deploy
inference_recommendation_id=inference_recommendation_id,
.tox/py37/lib/python3.7/site-packages/sagemaker/model.py:1301: in deploy
instance_type, accelerator_type, tags, serverless_inference_config
.tox/py37/lib/python3.7/site-packages/sagemaker/model.py:1800: in _create_sagemaker_model
tags=kwargs.get("tags"),
.tox/py37/lib/python3.7/site-packages/sagemaker/session.py:3548: in create_model
self._intercept_create_request(create_model_request, submit, self.create_model.__name__)
.tox/py37/lib/python3.7/site-packages/sagemaker/session.py:5427: in _intercept_create_request
return create(request)
.tox/py37/lib/python3.7/site-packages/sagemaker/session.py:3536: in submit
self.sagemaker_client.create_model(**request)
.tox/py37/lib/python3.7/site-packages/botocore/client.py:530: in _api_call
return self._make_api_call(operation_name, kwargs)
.tox/py37/lib/python3.7/site-packages/botocore/client.py:928: in _make_api_call
headers=additional_headers,
.tox/py37/lib/python3.7/site-packages/botocore/client.py:992: in _convert_to_request_dict
api_params, operation_model
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <botocore.validate.ParamValidationDecorator object at 0x7f9e449c1c50>
parameters = {'Containers': [{'ModelPackageName': None}], 'EnableNetworkIsolation': True, 'ExecutionRoleArn': 'arn:aws:iam::142577830533:role/SageMakerRole', 'ModelName': 'test-marketplace-1686350945-f70d-2023-06-09-22-51-43-805'}
operation_model = OperationModel(name=CreateModel)
def serialize_to_request(self, parameters, operation_model):
input_shape = operation_model.input_shape
if input_shape is not None:
report = self._param_validator.validate(
parameters, operation_model.input_shape
)
if report.has_errors():
> raise ParamValidationError(report=report.generate_report())
E botocore.exceptions.ParamValidationError: Parameter validation failed:
E Invalid type for parameter Containers[0].ModelPackageName, value: None, type: <class 'NoneType'>, valid types: <class 'str'>
.tox/py37/lib/python3.7/site-packages/botocore/validate.py:381: ParamValidationError
----------------------------- Captured stdout call -----------------------------
Testing done:
Merge Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mufaddal-rohawala
requested review from
trajanikant
and removed request for
a team
Issue #, if available:
Description of changes:
2 integ-tests are failing due to ParamValidation Error:
Can you take a look once
FAILED tests/integ/test_marketplace.py::test_marketplace_attach - botocore.ex...
FAILED tests/integ/test_marketplace.py::test_marketplace_transform_job - boto...
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.