Add features_to_explain to shap config #3951

oyangz · 2023-06-22T07:02:46Z

Issue #, if available: https://issues.amazon.com/issues/RAI-5317

Description of changes: Add features_to_explain to Clarify SHAPConfig

Testing done: tox tests passed

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-06-22T07:44:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: b1a25bd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T07:48:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: b1a25bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T07:57:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: b1a25bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T08:26:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: b1a25bd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T08:34:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: b1a25bd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T21:45:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6f3fde1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T21:54:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6f3fde1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T22:02:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6f3fde1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T22:31:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 6f3fde1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-22T22:36:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6f3fde1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-06-22T22:38:18Z

Codecov Report

Merging #3951 (d2924fb) into master (a8b6b1d) will decrease coverage by 0.72%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3951      +/-   ##
==========================================
- Coverage   90.32%   89.60%   -0.72%     
==========================================
  Files        1296      306     -990     
  Lines      114132    28231   -85901     
==========================================
- Hits       103088    25297   -77791     
+ Misses      11044     2934    -8110

Impacted Files	Coverage Δ
src/sagemaker/clarify.py	`97.49% <100.00%> (ø)`

... and 1601 files with indirect coverage changes

mufaddal-rohawala · 2023-06-23T17:43:38Z

src/sagemaker/clarify.py

+        if features_to_explain is not None and (
+            text_config is not None or image_config is not None
+        ):
+            raise ValueError(


please add this in method docstring

Sure, will do.

Added in latest commit.

malhotra18

LGTM!

sagemaker-bot · 2023-06-23T19:52:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: e04e555
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-23T20:56:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 96b5624
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-23T21:04:07Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 96b5624
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-23T21:11:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 96b5624
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-23T21:24:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 96b5624
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-23T21:46:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 96b5624
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-06T16:58:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d2924fb
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-06T17:06:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d2924fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-06T17:07:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d2924fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-06T17:29:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d2924fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-06T17:53:31Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d2924fb
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-07-06T18:54:28Z

Bypassing notebook tests (due to a known timeout issue), the timed out notebooks have been verified successfully atleast once in subsequent iterations.

Add features_to_explain to shap config

b1a25bd

oyangz marked this pull request as ready for review June 22, 2023 07:05

oyangz requested a review from a team as a code owner June 22, 2023 07:05

oyangz requested review from mufaddal-rohawala and removed request for a team June 22, 2023 07:05

Add to analysis config schema

6f3fde1

mufaddal-rohawala requested changes Jun 23, 2023

View reviewed changes

malhotra18 approved these changes Jun 23, 2023

View reviewed changes

Add raised error to SHAPConfig docstring

e04e555

Fix trailing whitespace

96b5624

oyangz requested a review from mufaddal-rohawala June 23, 2023 22:40

knikure assigned mufaddal-rohawala Jul 5, 2023

Merge branch 'master' into features_to_explain

d2924fb

mufaddal-rohawala approved these changes Jul 6, 2023

View reviewed changes

mufaddal-rohawala merged commit 6c1a3a1 into aws:master Jul 6, 2023

Add features_to_explain to shap config #3951

Add features_to_explain to shap config #3951

Uh oh!

Conversation

oyangz commented Jun 22, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 22, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mufaddal-rohawala Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

oyangz Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

oyangz Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

malhotra18 left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jun 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 23, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 6, 2023

codecov-commenter commented Jun 22, 2023 •

edited

Loading