fix: remove unnecessary get caller identity call #3960

evakravi · 2023-06-26T20:14:39Z

Issue #, if available:

Description of changes:
The implementation of resolve_model_sagemaker_config_field and resolve_estimator_sagemaker_config_field calls get_caller_identity_arn if default_value is None (See: https://github.com/aws/sagemaker-python-sdk/blob/master/src/sagemaker/jumpstart/utils.py#L514). When direct_input is not None (the customer specifies a role), we do not want to call get_caller_identity_arn, especially since it can fail it the permissions don't allow this, and cause excessive logging as a result. As a result, we should pass the role string as default_value, so that when a customer specifies a role, we do not call get_caller_identity_arn.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…-call

sagemaker-bot · 2023-06-26T20:20:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 37ed673
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/jumpstart/factory/estimator.py

sagemaker-bot · 2023-06-26T20:52:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 37ed673
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-26T21:07:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 37ed673
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-26T21:08:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 37ed673
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-26T21:27:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 37ed673
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-call

sagemaker-bot · 2023-06-29T20:30:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5c7a9fd
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-29T20:44:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5c7a9fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-29T20:54:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5c7a9fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-29T21:26:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5c7a9fd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-call

sagemaker-bot · 2023-06-29T23:44:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 82841ea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-29T23:53:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 82841ea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-29T23:57:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 82841ea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T00:33:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 82841ea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-06-30T00:35:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 82841ea
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-06-30T00:36:02Z

Codecov Report

Merging #3960 (2eb2802) into master (a8b6b1d) will decrease coverage by 0.73%.
The diff coverage is 100.00%.

❗ Current head 2eb2802 differs from pull request most recent head a7a404b. Consider uploading reports for the commit a7a404b to get more accurate results

@@            Coverage Diff             @@
##           master    #3960      +/-   ##
==========================================
- Coverage   90.32%   89.60%   -0.73%     
==========================================
  Files        1296      306     -990     
  Lines      114132    28230   -85902     
==========================================
- Hits       103088    25295   -77793     
+ Misses      11044     2935    -8109

Impacted Files	Coverage Δ
src/sagemaker/jumpstart/factory/estimator.py	`98.42% <ø> (ø)`
src/sagemaker/jumpstart/factory/model.py	`97.01% <ø> (ø)`
src/sagemaker/clarify.py	`97.49% <100.00%> (ø)`
src/sagemaker/djl_inference/model.py	`91.11% <100.00%> (ø)`

... and 1598 files with indirect coverage changes

…-call

sagemaker-bot · 2023-07-03T13:23:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 4bb2a99
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T13:41:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 4bb2a99
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T13:43:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 4bb2a99
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T14:21:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 4bb2a99
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-03T16:20:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 4bb2a99
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-call

sagemaker-bot · 2023-07-05T20:55:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: cad998e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-05T21:11:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: cad998e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-05T21:16:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: cad998e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-05T21:28:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: cad998e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-05T21:54:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: cad998e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-call

sagemaker-bot · 2023-07-06T21:17:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2eb2802
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-06T21:34:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2eb2802
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-06T21:40:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2eb2802
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run notebook-tests

sagemaker-bot · 2023-07-06T22:25:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2eb2802
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-06T22:34:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2eb2802
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T01:51:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2eb2802
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-call

sagemaker-bot · 2023-07-07T20:01:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: a7a404b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T20:22:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: a7a404b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T20:29:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: a7a404b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T21:09:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: a7a404b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T23:19:59Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: a7a404b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

fix: remove unnecessary get caller identity call

4072964

evakravi requested a review from a team as a code owner June 26, 2023 20:14

evakravi requested review from mufaddal-rohawala and removed request for a team June 26, 2023 20:14

Merge branch 'master' into fix/remove-unnecessary-get-caller-identity…

37ed673

…-call

whittech1 reviewed Jun 26, 2023

View reviewed changes

src/sagemaker/jumpstart/factory/estimator.py Show resolved Hide resolved

JGuinegagne approved these changes Jun 26, 2023

View reviewed changes

Merge branch 'master' into fix/remove-unnecessary-get-caller-identity…

5c7a9fd

…-call

Merge branch 'master' into fix/remove-unnecessary-get-caller-identity…

82841ea

…-call

Merge branch 'master' into fix/remove-unnecessary-get-caller-identity…

4bb2a99

…-call

knikure assigned mufaddal-rohawala Jul 5, 2023

Merge branch 'master' into fix/remove-unnecessary-get-caller-identity…

cad998e

…-call

Merge branch 'master' into fix/remove-unnecessary-get-caller-identity…

2eb2802

…-call

mufaddal-rohawala approved these changes Jul 6, 2023

View reviewed changes

mufaddal-rohawala reviewed Jul 6, 2023

View reviewed changes

Merge branch 'master' into fix/remove-unnecessary-get-caller-identity…

a7a404b

…-call

knikure merged commit fa3d6f1 into aws:master Jul 11, 2023

fix: remove unnecessary get caller identity call #3960

fix: remove unnecessary get caller identity call #3960

Uh oh!

Conversation

evakravi commented Jun 26, 2023

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 26, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 29, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jun 30, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 3, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 5, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 5, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 5, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jun 30, 2023 •

edited

Loading