chore: jumpstart deprecation messages #3992

evakravi · 2023-07-12T14:55:18Z

Issue #, if available:

Description of changes:
The SDK can now surface custom deprecation and deprecation warning messages for models. This is important because it allows JumpStart to communicate bespoke messages to customers, whereas before they were generic and led to confusion.

Testing done:
Unit tests written

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-07-12T15:01:02Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 220929a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

JGuinegagne · 2023-07-12T15:07:03Z

src/sagemaker/jumpstart/utils.py

@@ -402,11 +402,16 @@ def verify_model_region_and_return_specs(
            f"JumpStart model ID '{model_id}' and version '{version}' " "does not support training."
        )

-    if model_specs.deprecated:
+    if model_specs.deprecated or model_specs.deprecated_message:


remove the deprecated_message condition please, deprecated flag should be solely responsible for controlling whether to raise an exception. We can add a unit test in MH to enforce that deprecated is set to true when there is a deprecated_message.

sagemaker-bot · 2023-07-12T15:32:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 220929a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T15:36:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 220929a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T15:45:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 220929a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T16:49:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 9e20cb6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T17:30:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 24ae00e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T17:35:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 24ae00e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T17:46:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 24ae00e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-07-12T18:27:13Z

Codecov Report

Merging #3992 (0850b9b) into master (0a5b450) will decrease coverage by 0.67%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3992      +/-   ##
==========================================
- Coverage   90.13%   89.47%   -0.67%     
==========================================
  Files        1300      307     -993     
  Lines      114324    28276   -86048     
==========================================
- Hits       103048    25300   -77748     
+ Misses      11276     2976    -8300

Impacted Files	Coverage Δ
src/sagemaker/jumpstart/types.py	`97.61% <100.00%> (ø)`
src/sagemaker/jumpstart/validators.py	`90.69% <100.00%> (ø)`

... and 1605 files with indirect coverage changes

sagemaker-bot · 2023-07-12T18:28:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 24ae00e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T20:23:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 24ae00e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…n-messages

sagemaker-bot · 2023-07-19T14:49:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 18fffc8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-19T15:28:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 18fffc8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-19T15:33:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 18fffc8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-19T16:23:00Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 18fffc8
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-19T18:22:32Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 18fffc8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-24T11:49:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0850b9b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-24T11:52:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0850b9b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-24T12:07:43Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0850b9b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-24T12:30:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0850b9b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-24T12:48:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0850b9b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

chore: jumpstart deprecation messages

220929a

evakravi requested a review from a team as a code owner July 12, 2023 14:55

evakravi requested review from bhupendrasingh and removed request for a team July 12, 2023 14:55

evakravi marked this pull request as draft July 12, 2023 14:55

JGuinegagne requested changes Jul 12, 2023

View reviewed changes

chore: address PR comment

9e20cb6

fix: bad kwarg name

24ae00e

JGuinegagne approved these changes Jul 12, 2023

View reviewed changes

evakravi marked this pull request as ready for review July 19, 2023 14:41

Merge remote-tracking branch 'origin' into chore/jumpstart-deprecatio…

18fffc8

…n-messages

Merge branch 'master' into chore/jumpstart-deprecation-messages

0850b9b

knikure approved these changes Jul 24, 2023

View reviewed changes

knikure merged commit 219ad24 into aws:master Jul 24, 2023

gwengusc mentioned this pull request Jul 27, 2023

feature: support online store ttl for records #4030

Merged

9 tasks

chore: jumpstart deprecation messages #3992

chore: jumpstart deprecation messages #3992

Uh oh!

Conversation

evakravi commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

JGuinegagne Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Jul 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Jul 24, 2023

AWS CodeBuild CI Report

Uh oh!

Uh oh!

evakravi commented Jul 12, 2023 •

edited

Loading

codecov-commenter commented Jul 12, 2023 •

edited

Loading