-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: add jumpstart llama 2 tests #4004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@@ -29,6 +33,8 @@ | |||
|
|||
MAX_INIT_TIME_SECONDS = 5 | |||
|
|||
MODEL_PACKAGE_ARN_SUPPORTED_REGIONS = {"us-west-2", "us-east-1"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: this is going to expand very soon to 16 or so regions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I know. If I don't do this then the test would fail in the other regions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just FYI, we might only need IAD
, PDX,
DUBand
SIN` initially, and see if we receive PFRs
"hosting_eula_key": "fmhMetadata/eula/llamaEula.txt", | ||
"hosting_model_package_arns": { | ||
"us-west-2": "arn:aws:sagemaker:us-west-2:594846645681:model-package/" | ||
"llama2-7b-f-e46eb8a833643ed58aaccd81498972c3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be single line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this a multi-line string to shut-up flake8
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@@ -29,6 +33,8 @@ | |||
|
|||
MAX_INIT_TIME_SECONDS = 5 | |||
|
|||
MODEL_PACKAGE_ARN_SUPPORTED_REGIONS = {"us-west-2", "us-east-1"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just FYI, we might only need IAD
, PDX,
DUBand
SIN` initially, and see if we receive PFRs
Issue #, if available:
Description of changes:
Adds integration test coverage for JumpStart Llama V2 models. Also adds unit tests for ensuring that model package arns are used to create the sagemaker model.
Testing done:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.