-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Support to get latest monitoring execution processing logs #4036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
knikure
merged 1 commit into
aws:master
from
keshav-chandak:feature/latest_exeution_logs
Aug 14, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,6 +63,7 @@ | |
resolve_value_from_config, | ||
resolve_class_attribute_from_config, | ||
) | ||
from sagemaker.lineage._utils import get_resource_name_from_arn | ||
|
||
DEFAULT_REPOSITORY_NAME = "sagemaker-model-monitor-analyzer" | ||
|
||
|
@@ -768,6 +769,29 @@ def list_executions(self): | |
|
||
return monitoring_executions | ||
|
||
def get_latest_execution_logs(self, wait=False): | ||
"""Get the processing job logs for the most recent monitoring execution | ||
|
||
Args: | ||
wait (bool): Whether the call should wait until the job completes (default: False). | ||
|
||
Raises: | ||
ValueError: If no execution job or processing job for the last execution has run | ||
|
||
Returns: None | ||
""" | ||
monitoring_executions = self.sagemaker_session.list_monitoring_executions( | ||
monitoring_schedule_name=self.monitoring_schedule_name | ||
) | ||
if len(monitoring_executions["MonitoringExecutionSummaries"]) == 0: | ||
raise ValueError("No execution jobs were kicked off.") | ||
if "ProcessingJobArn" not in monitoring_executions["MonitoringExecutionSummaries"][0]: | ||
raise ValueError("Processing Job did not run for the last execution") | ||
job_arn = monitoring_executions["MonitoringExecutionSummaries"][0]["ProcessingJobArn"] | ||
Comment on lines
+787
to
+790
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment |
||
self.sagemaker_session.logs_for_processing_job( | ||
job_name=get_resource_name_from_arn(job_arn), wait=wait | ||
) | ||
|
||
def update_monitoring_alert( | ||
self, | ||
monitoring_alert_name: str, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add a "Will Raise" section in docstrings for these