Skip to content

feature: Add huggingface-llm 0.9.3 dlc images #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

tosterberg
Copy link
Contributor

@tosterberg tosterberg commented Aug 3, 2023

Issue #, if available:

Description of changes: Adding HF-TGI 0.9.3 release image.

Testing done: CI/CD testing and regional smoke tests for image.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tosterberg tosterberg marked this pull request as ready for review August 4, 2023 16:19
@tosterberg tosterberg requested a review from a team as a code owner August 4, 2023 16:19
@tosterberg tosterberg requested review from vpbhargav and removed request for a team August 4, 2023 16:19
Copy link
Member

@mufaddal-rohawala mufaddal-rohawala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run all

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 53ffa19
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 53ffa19
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 53ffa19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 53ffa19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 53ffa19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

Merging #4045 (53ffa19) into master (93e6e3c) will decrease coverage by 0.73%.
Report is 5 commits behind head on master.
The diff coverage is 90.74%.

@@            Coverage Diff             @@
##           master    #4045      +/-   ##
==========================================
- Coverage   90.20%   89.47%   -0.73%     
==========================================
  Files        1300      306     -994     
  Lines      114712    28392   -86320     
==========================================
- Hits       103476    25405   -78071     
+ Misses      11236     2987    -8249     
Files Changed Coverage Δ
src/sagemaker/workflow/clarify_check_step.py 96.93% <ø> (ø)
...rc/sagemaker/jumpstart/artifacts/model_packages.py 84.61% <80.00%> (ø)
src/sagemaker/jumpstart/artifacts/model_uris.py 95.65% <80.00%> (ø)
src/sagemaker/jumpstart/artifacts/script_uris.py 95.65% <80.00%> (ø)
src/sagemaker/jumpstart/factory/estimator.py 97.76% <92.85%> (ø)
src/sagemaker/djl_inference/model.py 91.11% <100.00%> (ø)
src/sagemaker/huggingface/llm_utils.py 75.00% <100.00%> (ø)
src/sagemaker/jumpstart/artifacts/__init__.py 100.00% <100.00%> (ø)
src/sagemaker/jumpstart/factory/model.py 99.27% <100.00%> (ø)
src/sagemaker/jumpstart/model.py 93.44% <100.00%> (ø)
... and 2 more

... and 1594 files with indirect coverage changes

@mufaddal-rohawala mufaddal-rohawala merged commit 3cafa53 into aws:master Aug 4, 2023
@tosterberg tosterberg deleted the hf-tgi-release branch August 4, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants