Skip to content

fix: change instance type for huggingface test to ml.g5.8xlarge #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix: change instance type for huggingface test to ml.g5.8xlarge #4046

merged 1 commit into from
Aug 7, 2023

Conversation

zuoyuanh
Copy link
Contributor

@zuoyuanh zuoyuanh commented Aug 4, 2023 •
edited
Loading

Issue #, if available:

Description of changes:

Previously we saw consistent failure of integ test failure due to CapacityError while running huggingface g5 tests. This is due to we don't have enough capacity for ml.g5.12xlarge in PDX. After checking capacity, switching to ml.g5.8xlarge.

Testing done:

Confirmed integ tests passed after the change.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zuoyuanh zuoyuanh added the do-not-merge Use when PR needs to be marked as do not merge label Aug 4, 2023
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6d0deda
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6d0deda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6d0deda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6d0deda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@zuoyuanh zuoyuanh removed the do-not-merge Use when PR needs to be marked as do not merge label Aug 4, 2023
@zuoyuanh zuoyuanh marked this pull request as ready for review August 4, 2023 08:32
@zuoyuanh zuoyuanh requested a review from a team as a code owner August 4, 2023 08:32
@zuoyuanh zuoyuanh requested review from mufaddal-rohawala and removed request for a team August 4, 2023 08:32
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 6d0deda
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6d0deda
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 6d0deda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 6d0deda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 6d0deda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023 •
edited
Loading

Codecov Report

Merging #4046 (6d0deda) into master (93e6e3c) will decrease coverage by 0.73%.
Report is 6 commits behind head on master.
The diff coverage is 90.38%.

@@            Coverage Diff             @@
##           master    #4046      +/-   ##
==========================================
- Coverage   90.20%   89.47%   -0.73%     
==========================================
  Files        1300      306     -994     
  Lines      114712    28392   -86320     
==========================================
- Hits       103476    25405   -78071     
+ Misses      11236     2987    -8249
Files Changed Coverage Δ
src/sagemaker/workflow/clarify_check_step.py 96.93% <ø> (ø)
...rc/sagemaker/jumpstart/artifacts/model_packages.py 84.61% <80.00%> (ø)
src/sagemaker/jumpstart/artifacts/model_uris.py 95.65% <80.00%> (ø)
src/sagemaker/jumpstart/artifacts/script_uris.py 95.65% <80.00%> (ø)
src/sagemaker/jumpstart/factory/estimator.py 97.76% <92.85%> (ø)
src/sagemaker/jumpstart/artifacts/__init__.py 100.00% <100.00%> (ø)
src/sagemaker/jumpstart/factory/model.py 99.27% <100.00%> (ø)
src/sagemaker/jumpstart/model.py 93.44% <100.00%> (ø)
src/sagemaker/jumpstart/types.py 97.66% <100.00%> (ø)
...agemaker/model_monitor/clarify_model_monitoring.py 89.87% <100.00%> (ø)

... and 1596 files with indirect coverage changes

@akrishna1995 akrishna1995 self-requested a review August 4, 2023 19:38
akrishna1995
akrishna1995 approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@akrishna1995 akrishna1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change :)

akrishna1995
akrishna1995 reviewed Aug 5, 2023
View reviewed changes
Copy link
Contributor

@akrishna1995 akrishna1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run pr

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6d0deda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala mufaddal-rohawala merged commit 67d8faa into aws:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrishna1995 akrishna1995 akrishna1995 approved these changes

@mufaddal-rohawala mufaddal-rohawala Awaiting requested review from mufaddal-rohawala mufaddal-rohawala is a code owner automatically assigned from aws/sagemaker-ml-frameworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zuoyuanh @sagemaker-bot @codecov-commenter @akrishna1995 @mufaddal-rohawala