-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: jumpstart instance type variants #4068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bhupendrasingh
merged 27 commits into
aws:master
from
evakravi:feat/jumpstart-instance-type-variants
Sep 22, 2023
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
2efa1e8
feat: jumpstart instance type variants
evakravi 8d527f8
fix: typo
evakravi c21d2e1
fix: failing tests
evakravi e9e99c6
fix: docstring
evakravi fd41f0b
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi 9f912e4
chore: support for local and local_gpu
evakravi 099d6f1
fix: variants -> regional_variants, properties -> regional_properties
evakravi 3e0d4f6
chore: fallback to legacy logic if no match found
evakravi 7666ee0
chore: add support for no ecr specs
evakravi 78d5911
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi c319e65
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi 001edaa
fix: flake8 line length
evakravi d9aa56f
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi 0f136e7
chore: address PR comments, add support for bad metadata fallback
evakravi f84d5ae
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi 76d5f4c
chore: remove unnecessary log, improve error message
evakravi 71ee0ad
chore: slight adjustment to image uri variant logic
evakravi e1d8d30
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi 6b6ccd1
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi 4299b8f
chore: improve error message
evakravi 2f22669
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi 3f42c15
fix: instance type found but image uri for family
evakravi 6ca6627
feat: instance type variants for environment variables
evakravi d87ce71
chore: address PR comments, fix formatting
evakravi 814d0cd
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi fb16dbb
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi 43947f5
Merge branch 'master' into feat/jumpstart-instance-type-variants
evakravi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.