feature: Neo service GA in TLV #4084

Qingzi-Lan · 2023-08-23T20:48:54Z

Description of changes:

Neo service GA in TLV, add TLV service account number
https://isengard.amazon.com/manage-accounts/275950707576/manage

Testing done:

unit test

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

knikure

/bot run all

sagemaker-bot · 2023-08-25T19:45:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 44f144f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T20:34:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 44f144f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T20:40:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 44f144f
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T20:57:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 44f144f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure · 2023-08-25T21:25:03Z

@Qingzi-Lan Can you fix the black-check errors by running tox -e black-format command?
Submit your changes after successfully running ./.githooks/pre-push command.

knikure · 2023-08-25T21:25:32Z

Meanwhile get this PR reviewed from someone in Neo team.

sagemaker-bot · 2023-08-25T23:21:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 44f144f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Qingzi-Lan · 2023-08-28T21:43:47Z

/bot run all

knikure

/bot run all

sagemaker-bot · 2023-08-28T22:49:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 93ca88b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-28T22:52:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 93ca88b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-28T23:33:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 93ca88b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-08-28T23:33:55Z

Codecov Report

Merging #4084 (93ca88b) into master (9517bdd) will decrease coverage by 0.74%.
Report is 7 commits behind head on master.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #4084      +/-   ##
==========================================
- Coverage   90.23%   89.50%   -0.74%     
==========================================
  Files        1312      312    -1000     
  Lines      115920    28675   -87245     
==========================================
- Hits       104599    25665   -78934     
+ Misses      11321     3010    -8311

Files Changed	Coverage Δ
src/sagemaker/remote_function/client.py	`96.93% <ø> (ø)`
src/sagemaker/stabilityai/stability_utils.py	`72.72% <72.72%> (ø)`
src/sagemaker/remote_function/job.py	`87.65% <83.33%> (ø)`
src/sagemaker/image_uris.py	`97.82% <100.00%> (ø)`
src/sagemaker/stabilityai/__init__.py	`100.00% <100.00%> (ø)`

... and 1619 files with indirect coverage changes

sagemaker-bot · 2023-08-28T23:57:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 93ca88b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T01:24:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 93ca88b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run pr, notebook-tests

sagemaker-bot · 2023-08-29T16:34:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 93ca88b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T16:58:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 93ca88b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala

/bot run notebook-tests

mufaddal-rohawala · 2023-08-29T20:31:53Z

This PR is just awaiting a pass for notebook tests, all other PR checks have already passed.

sagemaker-bot · 2023-08-29T21:57:01Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 158503d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Qingzi-Lan requested a review from a team as a code owner August 23, 2023 20:48

Qingzi-Lan requested review from EvelynYan21 and removed request for a team August 23, 2023 20:48

knikure self-assigned this Aug 25, 2023

feature: Neo service GA on TLV

44f144f

knikure force-pushed the master branch from 85bcb2f to 44f144f Compare August 25, 2023 19:39

knikure reviewed Aug 25, 2023

View reviewed changes

Qingzi-Lan and others added 3 commits August 28, 2023 12:21

Merge branch 'master' into master

d19e30a

fix typo

0ec766b

format

93ca88b

HappyAmazonian approved these changes Aug 28, 2023

View reviewed changes

knikure reviewed Aug 28, 2023

View reviewed changes

mnuyens approved these changes Aug 28, 2023

View reviewed changes

knikure reviewed Aug 29, 2023

View reviewed changes

mufaddal-rohawala reviewed Aug 29, 2023

View reviewed changes

Merge branch 'master' into master

158503d

knikure approved these changes Aug 29, 2023

View reviewed changes

knikure merged commit c56a7d1 into aws:master Aug 30, 2023

feature: Neo service GA in TLV #4084

feature: Neo service GA in TLV #4084

Uh oh!

Conversation

Qingzi-Lan commented Aug 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

knikure commented Aug 25, 2023

Uh oh!

knikure commented Aug 25, 2023

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

Qingzi-Lan commented Aug 28, 2023

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Aug 28, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 28, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 28, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Aug 28, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 29, 2023

AWS CodeBuild CI Report

Uh oh!

knikure left a comment

Choose a reason for hiding this comment

Uh oh!

sagemaker-bot commented Aug 29, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 29, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala left a comment • edited by knikure Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mufaddal-rohawala commented Aug 29, 2023

Uh oh!

sagemaker-bot commented Aug 29, 2023

AWS CodeBuild CI Report

Uh oh!

Uh oh!

Qingzi-Lan commented Aug 23, 2023 •

edited

Loading

codecov-commenter commented Aug 28, 2023 •

edited

Loading

mufaddal-rohawala left a comment •

edited by knikure

Loading