change: get python version dynamically for remote function tests #4089

benieric · 2023-08-24T22:54:52Z

Issue #, if available:

Description of changes:

Change tests/integ/sagemaker/remote_function/conftest.py to get python version dynamically instead of having it hard coded.
Change tests/data/remote_function/old_deps_requirements.txt to pandas version that will create correct test scenario when ran with py38+ in test_with_incompatible_dependencies()
- test_with_incompatible_dependencies() is expected to fail until pr tests are changed to run with py310 because it requires py38+

Testing done:

tox -e py310 -- -s -vv tests/integ/sagemaker/remote_function/test_decorator.py
tox -e py38 -- -s -vv tests/integ/sagemaker/remote_function/test_decorator.py
tox -e py37 -- -s -vv tests/integ/sagemaker/remote_function/test_decorator.py
- with expected failure of test_with_incompatible_dependencies() - test will fail until py37 is deprecated

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-08-24T22:57:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c2b7bc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-24T23:48:39Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c2b7bc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T00:03:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8cf28c0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T00:07:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8cf28c0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T00:09:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8cf28c0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T00:13:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8cf28c0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T00:57:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8cf28c0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T01:19:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8cf28c0
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T01:29:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8cf28c0
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T16:22:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 9c34d2f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T16:59:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T17:34:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T18:24:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T18:38:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T18:41:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c260aa1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T19:08:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-08-25T19:09:22Z

Codecov Report

Patch coverage: 82.60% and project coverage change: +0.11% 🎉

Comparison is base (9517bdd) 90.23% compared to head (0472607) 90.34%.
Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4089      +/-   ##
==========================================
+ Coverage   90.23%   90.34%   +0.11%     
==========================================
  Files        1312      312    -1000     
  Lines      115920    28676   -87244     
==========================================
- Hits       104599    25907   -78692     
+ Misses      11321     2769    -8552

Files Changed	Coverage Δ
src/sagemaker/remote_function/client.py	`97.54% <ø> (ø)`
src/sagemaker/workflow/utilities.py	`92.04% <ø> (ø)`
src/sagemaker/stabilityai/stability_utils.py	`72.72% <72.72%> (ø)`
src/sagemaker/remote_function/job.py	`89.75% <83.33%> (ø)`
src/sagemaker/image_uris.py	`97.83% <100.00%> (ø)`
src/sagemaker/stabilityai/__init__.py	`100.00% <100.00%> (ø)`

... and 1618 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sagemaker-bot · 2023-08-25T19:11:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T19:58:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T20:20:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c260aa1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T20:27:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-25T20:47:04Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

benieric

/bot run all

sagemaker-bot · 2023-08-29T20:18:51Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T20:23:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: c260aa1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T20:35:16Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T21:01:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: c260aa1
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-08-29T21:03:25Z

tests/integ/sagemaker/remote_function/conftest.py

+
+@pytest.fixture(scope="package")
+def incompatible_python_version():
+    return "{}.{}".format(sys.version_info.major, sys.version_info.minor + 1)


sagemaker-bot · 2023-08-29T21:14:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: c260aa1
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T21:22:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 0472607
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T22:14:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 0472607
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T22:28:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 0472607
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T22:58:20Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0472607
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-08-29T23:15:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 0472607
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

change: get python version dynamically for remote function tests

c2b7bc9

benieric requested a review from a team as a code owner August 24, 2023 22:54

benieric requested review from knikure and removed request for a team August 24, 2023 22:54

benieric added do-not-merge Use when PR needs to be marked as do not merge and removed do-not-merge Use when PR needs to be marked as do not merge labels Aug 24, 2023

chore: clarify comment

8cf28c0

chore: black-format

9c34d2f

fix: incompatible_python fixture

c260aa1

knikure self-assigned this Aug 25, 2023

benieric requested a review from mufaddal-rohawala August 29, 2023 17:20

knikure approved these changes Aug 29, 2023

View reviewed changes

benieric commented Aug 29, 2023

View reviewed changes

mufaddal-rohawala approved these changes Aug 29, 2023

View reviewed changes

Merge branch 'master' into master

0472607

nmadan approved these changes Aug 29, 2023

View reviewed changes

benieric merged commit 5f9a6be into aws:master Aug 29, 2023

change: get python version dynamically for remote function tests #4089

change: get python version dynamically for remote function tests #4089

Uh oh!

Conversation

benieric commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Aug 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 24, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Aug 25, 2023

AWS CodeBuild CI Report

Uh oh!

benieric left a comment

Choose a reason for hiding this comment

Uh oh!

benieric commented Aug 24, 2023 •

edited

Loading

codecov-commenter commented Aug 25, 2023 •

edited

Loading