feat: Added register step in Jumpstart model #4212

keshav-chandak · 2023-10-18T05:25:55Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-10-18T05:32:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: fc2aa1d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T05:54:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 75c5fe6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T07:19:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 5c0e59c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T07:25:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 5c0e59c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T07:29:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 5c0e59c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T07:30:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 5c0e59c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T08:10:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 5c0e59c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-10-18T08:10:39Z

Codecov Report

Attention: 64 lines in your changes are missing coverage. Please review.

Comparison is base (3057f21) 90.27% compared to head (2e4d73f) 90.30%.
Report is 48 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4212      +/-   ##
==========================================
+ Coverage   90.27%   90.30%   +0.03%     
==========================================
  Files         993      320     -673     
  Lines       87861    29677   -58184     
==========================================
- Hits        79313    26799   -52514     
+ Misses       8548     2878    -5670

Files	Coverage Δ
src/sagemaker/base_predictor.py	`90.90% <100.00%> (ø)`
src/sagemaker/config/config_schema.py	`100.00% <100.00%> (ø)`
src/sagemaker/estimator.py	`92.88% <ø> (ø)`
src/sagemaker/feature_store/feature_group.py	`78.82% <ø> (ø)`
...emaker/feature_store/feature_processor/__init__.py	`100.00% <100.00%> (ø)`
...eature_store/feature_processor/_config_uploader.py	`97.43% <100.00%> (ø)`
...aker/feature_store/feature_processor/_constants.py	`100.00% <100.00%> (ø)`
...er/feature_store/feature_processor/_data_source.py	`100.00% <100.00%> (ø)`
...agemaker/feature_store/feature_processor/_enums.py	`100.00% <100.00%> (ø)`
...ore/feature_processor/_feature_processor_config.py	`100.00% <100.00%> (ø)`
... and 49 more

... and 1254 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sagemaker-bot · 2023-10-18T11:14:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d967df9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T11:20:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d967df9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T11:28:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d967df9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T11:30:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d967df9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T12:07:18Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d967df9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T13:29:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: f310d82
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T13:30:29Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: f310d82
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T13:40:30Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: f310d82
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T13:48:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: f310d82
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-18T14:22:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: f310d82
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sthodimi

LGTM, can we also please get an approval from someone on the JumpStart team please ? If this was already approved in the staging repo, could you please link the CR here, I can take a look and approve this change.

sthodimi · 2023-10-18T18:10:45Z

@keshav-chandak could you also please resolve the merge conflicts

src/sagemaker/jumpstart/model.py

sagemaker-bot · 2023-10-19T06:52:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: bc5d530
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T08:00:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 2e4d73f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T08:09:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 2e4d73f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T08:18:19Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 2e4d73f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T08:33:40Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 2e4d73f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-10-19T08:58:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 2e4d73f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

evakravi · 2023-10-19T15:10:52Z

src/sagemaker/jumpstart/factory/model.py

+    register_kwargs.content_types = (
+        register_kwargs.content_types or model_specs.predictor_specs.supported_content_types
+    )
+    register_kwargs.response_types = (
+        register_kwargs.response_types or model_specs.predictor_specs.supported_accept_types
+    )


To confirm, all we're really doing is just setting the content type and accept types from the metadata

evakravi · 2023-10-19T15:13:05Z

src/sagemaker/jumpstart/types.py

+
+
+class JumpStartModelRegisterKwargs(JumpStartKwargs):
+    """Data class for the inputs to `JumpStartEstimator.deploy` method."""


docstring is wrong

evakravi · 2023-10-19T15:13:47Z

tests/integ/sagemaker/jumpstart/model/test_jumpstart_model.py

+
+    model_package = model.register()
+
+    # uses  instance


comment typo

Co-authored-by: Keshav Chandak <[email protected]>

keshav-chandak requested a review from a team as a code owner October 18, 2023 05:25

keshav-chandak requested review from sthodimi and removed request for a team October 18, 2023 05:25

keshav-chandak force-pushed the feature/jumpstart_register branch from 72396cc to fc2aa1d Compare October 18, 2023 05:26

keshav-chandak force-pushed the feature/jumpstart_register branch from fc2aa1d to 75c5fe6 Compare October 18, 2023 05:42

keshav-chandak changed the title ~~Added register step in Jumpstart model~~ feat: Added register step in Jumpstart model Oct 18, 2023

keshav-chandak force-pushed the feature/jumpstart_register branch from 75c5fe6 to 5c0e59c Compare October 18, 2023 06:21

keshav-chandak force-pushed the feature/jumpstart_register branch from 5c0e59c to d967df9 Compare October 18, 2023 10:18

keshav-chandak force-pushed the feature/jumpstart_register branch from d967df9 to f310d82 Compare October 18, 2023 12:33

knikure assigned sthodimi Oct 18, 2023

sthodimi reviewed Oct 18, 2023

View reviewed changes

saumitravikram reviewed Oct 19, 2023

View reviewed changes

src/sagemaker/jumpstart/model.py Show resolved Hide resolved

src/sagemaker/jumpstart/model.py Show resolved Hide resolved

keshav-chandak force-pushed the feature/jumpstart_register branch 3 times, most recently from 3534997 to bc5d530 Compare October 19, 2023 06:47

keshav-chandak force-pushed the feature/jumpstart_register branch from bc5d530 to 5018e95 Compare October 19, 2023 07:06

feat: Added register step in Jumpstart

2e4d73f

keshav-chandak force-pushed the feature/jumpstart_register branch from 5018e95 to 2e4d73f Compare October 19, 2023 07:07

saumitravikram approved these changes Oct 19, 2023

View reviewed changes

knikure approved these changes Oct 19, 2023

View reviewed changes

knikure merged commit 5acad56 into aws:master Oct 19, 2023

evakravi reviewed Oct 19, 2023

View reviewed changes

tests/integ/sagemaker/jumpstart/model/test_jumpstart_model.py

model_package = model.register()

# uses instance

Copy link

Member

evakravi Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment typo

knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request Oct 23, 2023

feat: Added register step in Jumpstart model (aws#4212)

4ff29f5

Co-authored-by: Keshav Chandak <[email protected]>

benieric pushed a commit to benieric/sagemaker-python-sdk that referenced this pull request Oct 24, 2023

feat: Added register step in Jumpstart model (aws#4212)

bfc272f

Co-authored-by: Keshav Chandak <[email protected]>



		class JumpStartModelRegisterKwargs(JumpStartKwargs):
		"""Data class for the inputs to `JumpStartEstimator.deploy` method."""

feat: Added register step in Jumpstart model #4212

feat: Added register step in Jumpstart model #4212

Uh oh!

Conversation

keshav-chandak commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Checklist

General

Tests

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 18, 2023

AWS CodeBuild CI Report

Uh oh!

sthodimi left a comment

Choose a reason for hiding this comment

Uh oh!

sthodimi commented Oct 18, 2023

Uh oh!

Uh oh!

Uh oh!

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

Uh oh!

sagemaker-bot commented Oct 19, 2023

AWS CodeBuild CI Report

keshav-chandak commented Oct 18, 2023 •

edited

Loading

codecov-commenter commented Oct 18, 2023 •

edited

Loading